Skip to content

Conversation

tommymcm
Copy link
Collaborator

@tommymcm tommymcm commented Jul 23, 2025

Implemented CXXDeleteExpr for concrete and virtual destructors.
NYI, global delete, i.e., ::delete.
Added tests for both destructor types.

Implemented missing handling for CXXDeleteExpr in CIRGen.
Added test for this expression case.
Implemented CIRGen for `CXXDeleteExpr` using a virtual destructor.
Added a test for `delete` using a virtual destructor.
@tommymcm tommymcm changed the title [CIR][CodeGen] Implemented uncovered case in CXXDeleteExpr [CIR][CodeGen] Implemented CXXDeleteExpr Jul 24, 2025
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nits

@bcardosolopes bcardosolopes merged commit 2ccc77e into llvm:main Jul 29, 2025
6 of 9 checks passed
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
Implemented `CXXDeleteExpr` for concrete and virtual destructors.
NYI, global delete, i.e., `::delete`.
Added tests for both destructor types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants