[CIR] Change record type alias prefix from !ty_ to !rec_ #1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the alias prefix for record types to make it less general.
|
As discussed on llvm/llvm-project#136387 |
erichkeane
approved these changes
Apr 22, 2025
| @@ -63,9 +63,9 @@ struct CIROpAsmDialectInterface : public OpAsmDialectInterface { | |||
| if (auto recordType = dyn_cast<cir::RecordType>(type)) { | |||
| StringAttr nameAttr = recordType.getName(); | |||
| if (!nameAttr) | |||
| os << "ty_anon_" << recordType.getKindAsStr(); | |||
| os << "rec_anon_" << recordType.getKindAsStr(); | |||
There was a problem hiding this comment.
not to do in this patch, but we discussed making this an 'assert' at one point, right?
There was a problem hiding this comment.
Yeah. I was going to do that separately.
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
This changes the alias prefix for record types to make it less general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the alias prefix for record types to make it less general.