Skip to content

[CIR][NFC] Simplify struct type name creation #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

[CIR][NFC] Simplify struct type name creation #1556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e6bf79
[CIR][NFC] Simplify struct type name creation
andykaylor Apr 10, 2025
a7e8dbc
Switch to using QualType::print
andykaylor Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 5 additions & 22 deletions clang/lib/CIR/CodeGen/CIRGenTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,31 +61,14 @@ std::string CIRGenTypes::getRecordTypeName(const clang::RecordDecl *recordDecl,

PrintingPolicy policy = recordDecl->getASTContext().getPrintingPolicy();
policy.SuppressInlineNamespace = false;
policy.AlwaysIncludeTypeForTemplateArgument = true;
policy.PrintCanonicalTypes = true;
policy.SuppressTagKeyword = true;

if (recordDecl->getIdentifier()) {
if (recordDecl->getDeclContext())
recordDecl->printQualifiedName(outStream, policy);
else
recordDecl->printName(outStream, policy);

// Ensure each template specialization has a unique name.
if (auto *templateSpecialization =
llvm::dyn_cast<ClassTemplateSpecializationDecl>(recordDecl)) {
outStream << '<';
const auto args = templateSpecialization->getTemplateArgs().asArray();
const auto printer = [&policy, &outStream](const TemplateArgument &arg) {
/// Print this template argument to the given output stream.
arg.print(policy, outStream, /*IncludeType=*/true);
};
llvm::interleaveComma(args, outStream, printer);
outStream << '>';
}

astContext.getRecordType(recordDecl).print(outStream, policy);
} else if (auto *typedefNameDecl = recordDecl->getTypedefNameForAnonDecl()) {
if (typedefNameDecl->getDeclContext())
typedefNameDecl->printQualifiedName(outStream, policy);
else
typedefNameDecl->printName(outStream);
typedefNameDecl->printQualifiedName(outStream, policy);
} else {
outStream << Builder.getUniqueAnonRecordName();
}
Expand Down
Loading