[CIR][CUDA] Handle clang builtin functions #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdUhTkJm
force-pushed
the
builtin
branch
2 times, most recently
from
cdd1075 to
a9bc4c8
Compare
bcardosolopes
requested changes
Mar 18, 2025
AdUhTkJm
force-pushed
the
builtin
branch
2 times, most recently
from
6fe06db to
45ea71f
Compare
AdUhTkJm
force-pushed
the
builtin
branch
2 times, most recently
from
d21e1f8 to
88f1709
Compare
bcardosolopes
approved these changes
Mar 25, 2025
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
Clang relies on `llvm::Intrinsic::getOrInsertDeclaration` to handle functions marked as `ClangBuiltin` in TableGen. That function receives a `CodeGenModule*` so CIR can't use that. We need to re-implement parts of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang relies on
llvm::Intrinsic::getOrInsertDeclarationto handle functions marked asClangBuiltinin TableGen. That function receives aCodeGenModule*so CIR can't use that. We need to re-implement parts of it.