Skip to content

cir-translate: Use default target triple instead of x86 if no target was set explicitly #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2025
Merged

cir-translate: Use default target triple instead of x86 if no target was set explicitly #1482

merged 3 commits into from
Mar 20, 2025

Conversation

mmha
Copy link
Collaborator

@mmha mmha commented Mar 13, 2025 •
edited
Loading

This is backported from a change made in llvm/llvm-project#131181

@mmha mmha mentioned this pull request Mar 13, 2025
Merged
Lancern
Lancern approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bcardosolopes
bcardosolopes requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change sounds good Morris, but some tests is failing on windows (see CI), perhaps you just need to force a target triple somewhere.

@mmha mmha force-pushed the incubator-cir-translate-default-triple branch 2 times, most recently from 505fdc5 to 9e555fb Compare March 18, 2025 02:52
@mmha
Copy link
Collaborator Author

mmha commented Mar 18, 2025

I added a default triple to the failing tests. These should probably be tracked in an issue since by the looks of it they are supposed to work on Windows. Here's the list of tests for reference:

CIR/Lowering/OpenMP/parallel.cir 
CIR/Lowering/OpenMP/taskwait.cir 
CIR/Lowering/OpenMP/taskyield.cir 
CIR/Lowering/array.cir 
CIR/Lowering/attribute-lowering.cir 
CIR/Lowering/binop-fp.cir 
CIR/Lowering/binop-overflow.cir 
CIR/Lowering/binop-unsigned-int.cir 
CIR/Lowering/bitint.cir 
CIR/Lowering/bool-to-int.cir 
CIR/Lowering/bool.cir 
CIR/Lowering/branch.cir 
CIR/Lowering/brcond.cir 
CIR/Lowering/bswap.cir 
CIR/Lowering/call-op-call-conv.cir 
CIR/Lowering/call.cir 
CIR/Lowering/cmp3way.cir 
CIR/Lowering/complex.cir 
CIR/Lowering/const-array.cir 
CIR/Lowering/expect.cir 
CIR/Lowering/func-call-conv.cir 
CIR/Lowering/globals.cir 
CIR/Lowering/if.cir 
CIR/Lowering/int-wrap.cir 
CIR/Lowering/intrinsics.cir 
CIR/Lowering/ptrdiff.cir 
CIR/Lowering/region-simplify.cir 
CIR/Lowering/scope.cir 
CIR/Lowering/select.cir 
CIR/Lowering/syncscope.cir 
CIR/Lowering/unary-inc-dec.cir 
CIR/Lowering/unary-not.cir 
CIR/Tools/cir-translate/warn-default-triple.cir

@bcardosolopes
Copy link
Member

Test updates looks good, but looks like there are remaining clang-format issues

@mmha mmha force-pushed the incubator-cir-translate-default-triple branch from 9e555fb to 918349a Compare March 19, 2025 17:15
bcardosolopes
bcardosolopes approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current failures are unrelated, let me land! Thanks

@bcardosolopes bcardosolopes merged commit 4d480b5 into llvm:main Mar 20, 2025
6 of 9 checks passed
@bcardosolopes bcardosolopes mentioned this pull request Mar 20, 2025
Merged
bcardosolopes added a commit that referenced this pull request Mar 20, 2025
@bcardosolopes
Revert "cir-translate: Use default target triple instead of x86 if no…
79faa08 
… target was set explicitly" (#1509)

Reverts #1482

@mmha this is crashing on macos on asserts build:
```
FAIL: Clang :: CIR/Tools/cir-translate/warn-default-triple.cir (472 of 552)
******************** TEST 'Clang :: CIR/Tools/cir-translate/warn-default-triple.cir' FAILED ********************
Exit Code: 134

Command Output (stdout):
--
Assertion failed: (!DataLayoutString.empty() && "Uninitialized DataLayout!"), function getDataLayoutString, file TargetInfo.h, line 1282.
```

Perhaps besides picking a default you maybe need to do some missing
datalayout init?
el-ev pushed a commit to el-ev/clangir that referenced this pull request Mar 21, 2025
@mmha @el-ev
cir-translate: Use default target triple instead of x86 if no target …
871624b 
…was set explicitly (llvm#1482)

This is backported from a change made in
llvm/llvm-project#131181

---------

Co-authored-by: Morris Hafner <[email protected]>
el-ev pushed a commit to el-ev/clangir that referenced this pull request Mar 21, 2025
@bcardosolopes @el-ev
Revert "cir-translate: Use default target triple instead of x86 if no…
83ea3c8 
… target was set explicitly" (llvm#1509)

Reverts llvm#1482

@mmha this is crashing on macos on asserts build:
```
FAIL: Clang :: CIR/Tools/cir-translate/warn-default-triple.cir (472 of 552)
******************** TEST 'Clang :: CIR/Tools/cir-translate/warn-default-triple.cir' FAILED ********************
Exit Code: 134

Command Output (stdout):
--
Assertion failed: (!DataLayoutString.empty() && "Uninitialized DataLayout!"), function getDataLayoutString, file TargetInfo.h, line 1282.
```

Perhaps besides picking a default you maybe need to do some missing
datalayout init?
el-ev pushed a commit to el-ev/clangir that referenced this pull request Mar 21, 2025
@mmha @el-ev
cir-translate: Use default target triple instead of x86 if no target …
1105d31 
…was set explicitly (llvm#1482)

This is backported from a change made in
llvm/llvm-project#131181

---------

Co-authored-by: Morris Hafner <[email protected]>
el-ev pushed a commit to el-ev/clangir that referenced this pull request Mar 21, 2025
@bcardosolopes @el-ev
Revert "cir-translate: Use default target triple instead of x86 if no…
66cb7f3 
… target was set explicitly" (llvm#1509)

Reverts llvm#1482

@mmha this is crashing on macos on asserts build:
```
FAIL: Clang :: CIR/Tools/cir-translate/warn-default-triple.cir (472 of 552)
******************** TEST 'Clang :: CIR/Tools/cir-translate/warn-default-triple.cir' FAILED ********************
Exit Code: 134

Command Output (stdout):
--
Assertion failed: (!DataLayoutString.empty() && "Uninitialized DataLayout!"), function getDataLayoutString, file TargetInfo.h, line 1282.
```

Perhaps besides picking a default you maybe need to do some missing
datalayout init?
el-ev pushed a commit to el-ev/clangir that referenced this pull request Mar 24, 2025
@mmha @el-ev
cir-translate: Use default target triple instead of x86 if no target …
80dd69e 
…was set explicitly (llvm#1482)

This is backported from a change made in
llvm/llvm-project#131181

---------

Co-authored-by: Morris Hafner <[email protected]>
el-ev pushed a commit to el-ev/clangir that referenced this pull request Mar 24, 2025
@bcardosolopes @el-ev
Revert "cir-translate: Use default target triple instead of x86 if no…
ab322c0 
… target was set explicitly" (llvm#1509)

Reverts llvm#1482

@mmha this is crashing on macos on asserts build:
```
FAIL: Clang :: CIR/Tools/cir-translate/warn-default-triple.cir (472 of 552)
******************** TEST 'Clang :: CIR/Tools/cir-translate/warn-default-triple.cir' FAILED ********************
Exit Code: 134

Command Output (stdout):
--
Assertion failed: (!DataLayoutString.empty() && "Uninitialized DataLayout!"), function getDataLayoutString, file TargetInfo.h, line 1282.
```

Perhaps besides picking a default you maybe need to do some missing
datalayout init?
el-ev pushed a commit to el-ev/clangir that referenced this pull request Mar 24, 2025
@mmha @el-ev
cir-translate: Use default target triple instead of x86 if no target …
23f3d4a 
…was set explicitly (llvm#1482)

This is backported from a change made in
llvm/llvm-project#131181

---------

Co-authored-by: Morris Hafner <[email protected]>
el-ev pushed a commit to el-ev/clangir that referenced this pull request Mar 24, 2025
@bcardosolopes @el-ev
Revert "cir-translate: Use default target triple instead of x86 if no…
658a756 
… target was set explicitly" (llvm#1509)

Reverts llvm#1482

@mmha this is crashing on macos on asserts build:
```
FAIL: Clang :: CIR/Tools/cir-translate/warn-default-triple.cir (472 of 552)
******************** TEST 'Clang :: CIR/Tools/cir-translate/warn-default-triple.cir' FAILED ********************
Exit Code: 134

Command Output (stdout):
--
Assertion failed: (!DataLayoutString.empty() && "Uninitialized DataLayout!"), function getDataLayoutString, file TargetInfo.h, line 1282.
```

Perhaps besides picking a default you maybe need to do some missing
datalayout init?
lanza pushed a commit to lanza/llvm-project that referenced this pull request Aug 11, 2025
@bcardosolopes @lanza
Revert "cir-translate: Use default target triple instead of x86 if no…
1199d05 
… target was set explicitly" (llvm#1509)

Reverts llvm/clangir#1482

@mmha this is crashing on macos on asserts build:
```
FAIL: Clang :: CIR/Tools/cir-translate/warn-default-triple.cir (472 of 552)
******************** TEST 'Clang :: CIR/Tools/cir-translate/warn-default-triple.cir' FAILED ********************
Exit Code: 134

Command Output (stdout):
--
Assertion failed: (!DataLayoutString.empty() && "Uninitialized DataLayout!"), function getDataLayoutString, file TargetInfo.h, line 1282.
```

Perhaps besides picking a default you maybe need to do some missing
datalayout init?
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
@mmha @lanza
cir-translate: Use default target triple instead of x86 if no target …
d68bbac 
…was set explicitly (llvm#1482)

This is backported from a change made in
llvm/llvm-project#131181

---------

Co-authored-by: Morris Hafner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@Lancern Lancern Lancern approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmha @bcardosolopes @Lancern