Skip to content

Conversation

FantasqueX
Copy link
Collaborator

I noticed that AtomicFenceOp doesn't use OptionalAttr like mlir llvmir. As a result, getLLVMSyncScope does't return std::optional. Should I use Arg instead?

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! One nit and should be good

@bcardosolopes bcardosolopes merged commit a018447 into llvm:main Mar 1, 2025
6 checks passed
lanza pushed a commit that referenced this pull request Mar 18, 2025
I noticed that `AtomicFenceOp` doesn't use `OptionalAttr` like mlir
llvmir. As a result, `getLLVMSyncScope` does't return `std::optional`.
Should I use `Arg` instead?
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
I noticed that `AtomicFenceOp` doesn't use `OptionalAttr` like mlir
llvmir. As a result, `getLLVMSyncScope` does't return `std::optional`.
Should I use `Arg` instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants