[CIR] Simplify FuncType printer/parser #1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlauko
force-pushed
the
xlauko/function-type-format
branch
from
2870048 to
ead1ba1
Compare
bcardosolopes
approved these changes
Feb 26, 2025
|
(cc @dkolsen-pgi) |
dkolsen-pgi
added a commit
to dkolsen-pgi/llvm-project
that referenced
this pull request
Feb 26, 2025
Incorporate llvm/clangir#1413 to simplify the parsing/printing of `FuncType`. Get rid of `FuncOp::verifyType` which did nothing useful.
xlauko
added a commit
to xlauko/clangir
that referenced
this pull request
Feb 28, 2025
This uses the assembly format for the optional return type and keeps a custom printer/parser only for function parameters, which still require a custom form for ellipses.
xlauko
added a commit
to xlauko/clangir
that referenced
this pull request
Feb 28, 2025
This uses the assembly format for the optional return type and keeps a custom printer/parser only for function parameters, which still require a custom form for ellipses.
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
This uses the assembly format for the optional return type and keeps a custom printer/parser only for function parameters, which still require a custom form for ellipses.
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
This uses the assembly format for the optional return type and keeps a custom printer/parser only for function parameters, which still require a custom form for ellipses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the assembly format for the optional return type and keeps a custom printer/parser only for function parameters, which still require a custom form for ellipses.