Skip to content

[CIR] Remove redundant BoolType customAssemblyFormat (NFC) #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[CIR] Remove redundant BoolType customAssemblyFormat (NFC) #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions clang/include/clang/CIR/Dialect/IR/CIRTypes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,6 @@ def CIR_BoolType :
let description = [{
`cir.bool` represent's C++ bool type.
}];

let hasCustomAssemblyFormat = 1;
}

//===----------------------------------------------------------------------===//
Expand Down
6 changes: 0 additions & 6 deletions clang/lib/CIR/Dialect/IR/CIRTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,6 @@ void CIRDialect::printType(Type type, DialectAsmPrinter &os) const {
});
}

Type BoolType::parse(mlir::AsmParser &parser) {
return get(parser.getContext());
}

void BoolType::print(mlir::AsmPrinter &printer) const {}

//===----------------------------------------------------------------------===//
// StructType Definitions
//===----------------------------------------------------------------------===//
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CIR/IR/invalid.cir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,7 +1486,7 @@ cir.global external @f = #cir.fp<42> : !cir.float
// Verify
!s32i = !cir.int<s, 32>
cir.func @cast0(%arg0: !s32i, %arg1: !s32i) {
// expected-error @below {{custom op 'cir.cmp' invalid kind of Type specified}}
// expected-error @below {{custom op 'cir.cmp' invalid kind of type specified}}
%1 = cir.cmp(eq, %arg0, %arg1): !s32i, !s32i
cir.return
}
Expand Down