Skip to content

[CIR] Add support for comparisons between pointers to member functions #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Feb 23, 2025

The CIRGen support is already there. This PR adds LLVM lowering support for comparisons between pointers to member functions. Note that pointers to member functions could only be compared for equality.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nit

The CIRGen support is already there. This patch adds LLVM lowering support for
comparisons between pointers to member functions. Note that pointers to member
functions could only be compared for equality.
@Lancern Lancern merged commit aff6245 into llvm:main Feb 25, 2025
6 checks passed
@Lancern Lancern deleted the memfunc-ptr-cmp branch February 25, 2025 06:11
lanza pushed a commit that referenced this pull request Mar 18, 2025
#1390)

The CIRGen support is already there. This PR adds LLVM lowering support
for comparisons between pointers to member functions. Note that pointers
to member functions could only be compared for equality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants