Skip to content

[CIR] Add support for __builtin_bitreverse #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Feb 22, 2025

This PR adds CIRGen and LLVM lowering support for the __builtin_bitreverse family of builtin functions.

@FantasqueX
Copy link
Collaborator

Since lowering of BitReverseOp is trivial, maybe add a field let llvmOp = "BitReverseOp"; is more appropriate?

@Lancern
Copy link
Member Author

Lancern commented Feb 24, 2025

Since lowering of BitReverseOp is trivial, maybe add a field let llvmOp = "BitReverseOp"; is more appropriate?

Thanks for pointing out, nearly missed this, will update later.

This patch adds CIRGen and LLVM lowering support for the `__builtin_bitreverse`
family of builtin functions.
@Lancern
Copy link
Member Author

Lancern commented Feb 24, 2025

Updated.

@bcardosolopes
Copy link
Member

@FantasqueX just bumped your github access so you can LGTM PRs as well, thanks for helping with reviews, much appreciated

@bcardosolopes bcardosolopes merged commit e607e3f into llvm:main Feb 24, 2025
6 checks passed
@Lancern Lancern deleted the builtin-bitreverse branch February 25, 2025 00:36
lanza pushed a commit that referenced this pull request Mar 18, 2025
This PR adds CIRGen and LLVM lowering support for the
`__builtin_bitreverse` family of builtin functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants