[CIR][Doc][NFC] Add a description for all the passes #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some passes not declared with TableGen did not have descriptions.
smeenai
approved these changes
Jan 13, 2025
bcardosolopes
approved these changes
Jan 13, 2025
| @@ -1356,7 +1356,11 @@ struct ConvertCIRToLLVMPass | |||
|
|
|||
| void processCIRAttrs(mlir::ModuleOp moduleOp); | |||
|
|
|||
| virtual StringRef getArgument() const override { return "cir-flat-to-llvm"; } | |||
| StringRef getDescription() const override { | |||
| return "Convert the prepared CIR dialect module to LLVM dialect"; | |||
There was a problem hiding this comment.
Can we get that for free by adding let description for these passes?
There was a problem hiding this comment.
I do not think these passes are described in a TableGen file.
Do you mean we should define them in a TableGen file first and then add such a description there?
You should have done some suggestions! 😄 |
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
Some passes not declared with TableGen did not have descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some passes not declared with TableGen did not have descriptions.