Skip to content

[CIR][CIRGen][Builtin][Neon] Lower vabsh_f16 #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

[CIR][CIRGen][Builtin][Neon] Lower vabsh_f16 #1269

merged 1 commit into from
Jan 9, 2025

Conversation

AmrDeveloper
Copy link
Member

Lower vabsh_f16

CG:

clangir/clang/lib/CodeGen/CGBuiltin.cpp

Lines 11975 to 11977 in 25b269e

case NEON::BI__builtin_neon_vabsh_f16:
Ops.push_back(EmitScalarExpr(E->getArg(0)));
return EmitNeonCall(CGM.getIntrinsic(Intrinsic::fabs, HalfTy), Ops, "vabs");

bcardosolopes
bcardosolopes approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit 6e24255 into llvm:main Jan 9, 2025
6 of 7 checks passed
lanza pushed a commit that referenced this pull request Mar 18, 2025
@AmrDeveloper @lanza
[CIR][CIRGen][Builtin][Neon] Lower vabsh_f16 (#1269)
55181f0 
Lower `vabsh_f16`

CG:
https://github.com/llvm/clangir/blob/25b269e5fed544e1da37b72bc32315c0ae0c5aa6/clang/lib/CodeGen/CGBuiltin.cpp#L11975-L11977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmrDeveloper @bcardosolopes