Skip to content

[CIR][ThroughMLIR][NFC] BinOpKind_Max NYI ThroughMLIR lowering #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2024
Merged

[CIR][ThroughMLIR][NFC] BinOpKind_Max NYI ThroughMLIR lowering #1233

merged 1 commit into from
Dec 13, 2024

Conversation

ghehg
Copy link
Contributor

@ghehg ghehg commented Dec 12, 2024 •
edited
Loading

No description provided.

@ghehg ghehg changed the title [CIR][Dialect] BinOpKind_Max LLVM lowering float type and NYI ThroughMLIR lowering [CIR][Dialect] BinOpKind_Max LLVM lowering floating types and NYI ThroughMLIR lowering Dec 12, 2024
@ghehg ghehg changed the title [CIR][Dialect] BinOpKind_Max LLVM lowering floating types and NYI ThroughMLIR lowering [CIR][Dialect] BinOpKind_Max NYI ThroughMLIR lowering Dec 12, 2024
@ghehg ghehg changed the title [CIR][Dialect] BinOpKind_Max NYI ThroughMLIR lowering [CIR][ThroughMLIR][NFC] BinOpKind_Max NYI ThroughMLIR lowering Dec 12, 2024
@ghehg ghehg marked this pull request as ready for review December 13, 2024 13:03
smeenai
smeenai approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@smeenai smeenai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work for now, merging to get us clean of all warnings again :)

@smeenai smeenai merged commit a989ecb into llvm:main Dec 13, 2024
8 checks passed
lanza pushed a commit that referenced this pull request Mar 18, 2025
@ghehg @lanza
[CIR][ThroughMLIR][NFC] BinOpKind_Max NYI ThroughMLIR lowering (#1233)
129feaa
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
@ghehg @lanza
[CIR][ThroughMLIR][NFC] BinOpKind_Max NYI ThroughMLIR lowering (llvm#…
2826e0b 
…1233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smeenai smeenai smeenai approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@bcardosolopes bcardosolopes Awaiting requested review from bcardosolopes bcardosolopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghehg @smeenai