Skip to content

Conversation

ghehg
Copy link
Contributor

@ghehg ghehg commented Nov 26, 2024

Added a few FIXMEs. There are 2 types of FIXMEs;

  1. Most of them are missing func call and parameter attributes. I didn't add for all missing sites for this type as it would have been just copy pastes.
  2. FIXME in lambda __invoke(): OG simply returns but CIR generates call to llvm.trap. This is just temporary and we will fix in in near future. But I feel I should still list those IRs so once we fix problem with codegen of invoke, we'd get test failure on this one and fix it. Actually, this way, this test file would be a natural test case for implementation of invoke.

@ghehg ghehg marked this pull request as ready for review November 26, 2024 15:16
@bcardosolopes bcardosolopes merged commit 70a2723 into llvm:main Nov 27, 2024
9 checks passed
lanza pushed a commit that referenced this pull request Mar 18, 2025
Added a few FIXMEs. There are 2 types of FIXMEs;
1. Most of them are missing func call and parameter attributes. I didn't
add for all missing sites for this type as it would have been just copy
pastes.
2. FIXME in lambda __invoke(): OG simply returns but CIR generates call
to llvm.trap. This is just temporary and we will fix in in near future.
But I feel I should still list those IRs so once we fix problem with
codegen of invoke, we'd get test failure on this one and fix it.
Actually, this way, this test file would be a natural test case for
implementation of invoke.
terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request Sep 2, 2025
Added a few FIXMEs. There are 2 types of FIXMEs;
1. Most of them are missing func call and parameter attributes. I didn't
add for all missing sites for this type as it would have been just copy
pastes.
2. FIXME in lambda __invoke(): OG simply returns but CIR generates call
to llvm.trap. This is just temporary and we will fix in in near future.
But I feel I should still list those IRs so once we fix problem with
codegen of invoke, we'd get test failure on this one and fix it.
Actually, this way, this test file would be a natural test case for
implementation of invoke.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants