[CIR][Lowering] Supports varargs in the CallingConvention pass #1005
+32
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
bcardosolopes
requested changes
Oct 26, 2024
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Thanks for working on all these lowering issues, this is great! Some nit and good to go.
Collaborator
Author
|
@bcardosolopes done! |
bcardosolopes
requested changes
Oct 28, 2024
bcardosolopes
approved these changes
Oct 29, 2024
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This PR adds several copy-pasted lines and a small test and now var args seems to work in the calling convention pass
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
This PR adds several copy-pasted lines and a small test and now var args seems to work in the calling convention pass
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
…1005) This PR adds several copy-pasted lines and a small test and now var args seems to work in the calling convention pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several copy-pasted lines and a small test and now var args seems to work in the calling convention pass