[CIR][ABI][AArch64][Lowering] Initial support for return of struct types #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
bcardosolopes
requested changes
Oct 26, 2024
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Sorry it took a while, LLVM Dev meeting this week got us all busy.
This looks almost good, just some missing feature asserts needed
clang/lib/CIR/Dialect/Transforms/TargetLowering/Targets/AArch64.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/TargetLowering/Targets/AArch64.cpp
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@bcardosolopes done, added missing features |
bcardosolopes
approved these changes
Oct 28, 2024
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
LGTM, will merge once format issues from buildbots are fixed + minor render script removal
bcardosolopes
requested changes
Oct 28, 2024
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Seems like it's also failing lit tests, marking this as needing changes
bcardosolopes
changed the title
bcardosolopes
approved these changes
Oct 29, 2024
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
…pes (#1004) This PR adds a support for return values of a struct type. There are two cases that are not covered by this PR and will be added later.
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
…pes (#1004) This PR adds a support for return values of a struct type. There are two cases that are not covered by this PR and will be added later.
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
…pes (llvm#1004) This PR adds a support for return values of a struct type. There are two cases that are not covered by this PR and will be added later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a support for return values of a struct type. There are two cases that are not covered by this PR and will be added later.