fix: Added a bug fix when registering new models #3453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omaryashraf5
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan,
leseb,
bbrowning,
reluctantfuturist,
mattf and
slekkala1
as code owners
meta-cla
bot
added
the
CLA Signed
ashwinb
reviewed
Sep 15, 2025
| # warn if the object's providerid already exists but proceed with registration | ||
| if existing_obj and existing_obj.provider_id == obj.provider_id: | ||
| return False | ||
| logger.warning( |
There was a problem hiding this comment.
you should warn if the provider is different -- that means an existing object is switching a provider and is perhaps a cause for concern / unanticipated.
There was a problem hiding this comment.
Thanks, @ashwinb Updated the check
There was a problem hiding this comment.
minor nit: this message isn't quite readable. can you make it more succinct please?
There was a problem hiding this comment.
@omaryashraf5 @ashwinb the warning will not be visible to anyone but the stack admin. imho, the right behavior is to reject the change with a message that the caller can see. the message should suggest unregistering first.
omaryashraf5
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modified the code in registry.py.
The key changes are:
return Falsestatement