Use .fwf format for both datasets #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other dataset has a header. If we follow the instructions in the tutorial, then nothing will work properly because this file has no header. Rather than force beginners to workaround this difference (can be done a few different ways, as we discussed in llSourcell#4 (comment)), the addition of the header row to keep the datasets consistent will make it much easier. In my opinion, everyone wants to learn to do linear regression, to use pandas, to use tensorflow, and to adapt to differences in data files. However, they don't all need to be done at the same time! Simply by adding the header row, the two files are consistent, learners find out the basics of pandas but not the complexities of adapting to differences in formats. Alternately, add the .fwf file and keep the .txt file as a "bonus" challenge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other dataset has a header. If we follow the instructions in the tutorial, then nothing will work properly because this file has no header.
Rather than force beginners to workaround this difference (can be done a few different ways, as we discussed in #4 (comment)), the addition of the header row to keep the datasets consistent will make it much easier.
In my opinion, everyone wants to learn to do linear regression, to use pandas, to use tensorflow, and to adapt to differences in data files. However, they don't all need to be done at the same time! Simply by adding the header row, the two files are consistent, learners find out the basics of pandas but not the complexities of adapting to differences in formats.
Alternately, add the .fwf file and keep the .txt file as a "bonus" challenge.