Skip to content

Use native implementations of Object.keys and Array.isArray #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Use native implementations of Object.keys and Array.isArray #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2d8cda
[meta] BREAKING: Increase minimum node version from 0.4 to 0.10
legobeat Feb 1, 2024
abecbcb
[Refactor] Replace object-keys with native Object.keys
legobeat Feb 1, 2024
e0f1c4c
[Refactor] Replace isarray with native Object.isArray
legobeat Feb 1, 2024
8b53f17
[actions] Remove node.js v0.6 from test matrix
legobeat Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/node-aught.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
tests:
uses: ljharb/actions/.github/workflows/node.yml@main
with:
range: '< 10'
range: '>= 0.10 < 10'
type: minors
command: npm run tests-only

Expand Down
6 changes: 2 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

var jsonStringify = (typeof JSON !== 'undefined' ? JSON : require('jsonify')).stringify;

var isArray = require('isarray');
var objectKeys = require('object-keys');
var callBind = require('call-bind');
var callBound = require('call-bind/callBound');

Expand Down Expand Up @@ -56,7 +54,7 @@ module.exports = function stableStringify(obj) {
if (typeof node !== 'object' || node === null) {
return jsonStringify(node);
}
if (isArray(node)) {
if (Array.isArray(node)) {
var out = [];
for (var i = 0; i < node.length; i++) {
var item = stringify(node, i, node[i], level + 1) || jsonStringify(null);
Expand All @@ -70,7 +68,7 @@ module.exports = function stableStringify(obj) {
throw new TypeError('Converting circular structure to JSON');
} else { $push(seen, node); }

var keys = objectKeys(node).sort(cmp && cmp(node));
var keys = Object.keys(node).sort(cmp && cmp(node));
var out = [];
for (var i = 0; i < keys.length; i++) {
var key = keys[i];
Expand Down
6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
"main": "index.js",
"dependencies": {
"call-bind": "^1.0.5",
"isarray": "^2.0.5",
"jsonify": "^0.0.1",
"object-keys": "^1.1.1"
"jsonify": "^0.0.1"
},
"devDependencies": {
"@ljharb/eslint-config": "^21.1.0",
Expand Down Expand Up @@ -66,7 +64,7 @@
},
"license": "MIT",
"engines": {
"node": ">= 0.4"
"node": ">= 0.10"
},
"auto-changelog": {
"output": "CHANGELOG.md",
Expand Down