-
Notifications
You must be signed in to change notification settings - Fork 9
Agent state visualization #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent state visualization #20
Conversation
Use for testing livekit-examples/agent-starter-swift#4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me and seems ok to duplicate the bar although you might consider unifying their options in a separate struct that they both consume to reduce documentation duplication
as to the thought about forcing re-renders: I agree with that and open to ideas that make it easier to use.
Yes, we should agree on a convention here, e.g.
I think the cleanest approach would be to create a |
Maybe this is less ugly without altering |
Pretty cool! agent-vis.mov |
We need to do that manually unfortunately playing with phases, but let's see 🤞 |
@hiroshihorie 371c55b should do the trick, feel free to adjust the timing/curve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect ✅
AgentBarAudioVisualizer
PhaseAnimator
that would need a "step" animation curve to achieve the desired effects without.delay
, also we cannot simply reset the animationBarAudioVisualizer
anymore, as we need item-based opacityAudioProcessor
into a separate fileConsiderations
.id(track)
or explicitif
around empty track state to reinstantiate@StateObject
of audio processor (and make it update the waveform) which is sort of a leaky abstraction - a separate initializer with non-optional track would be probably better