Skip to content

fix: fix h264 freeze when cipherText contains more than 2 consecutive zeros. #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 19, 2023
Merged

fix: fix h264 freeze when cipherText contains more than 2 consecutive zeros. #877

merged 6 commits into from
Sep 19, 2023

Conversation

cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc commented Sep 18, 2023 •
edited
Loading

The corresponding patch for libwebrtc,
webrtc-sdk/webrtc#93

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 85182e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 76.52 KB (0%)
dist/livekit-client.umd.js 82.13 KB (+0.2% 🔺)

lukasIO
lukasIO reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, just some minor comments.

lukasIO
lukasIO approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@cloudwebrtc cloudwebrtc merged commit 6351244 into main Sep 19, 2023
@cloudwebrtc cloudwebrtc deleted the duan/e2ee-fix-h264-freeze branch September 19, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasIO lukasIO lukasIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudwebrtc @lukasIO