set btn outside of if block #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. And this is the first pr I have received. :) I am very happy that these code could help you. :) |
|
My first pr also :) |
|
Any chance that you could tag a release with this change in it? Thanks. |
|
Ok. done for now. Sorry for that cus I have went to JSConf China in recent days. |
|
No problem Leigh. Thanks. On 24 June 2014 02:53, Leigh [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
First off, thanks for this lib. It saved me the effort :)
I was trying to use the lib to clip to an existing element on my page but could not get it to work. When I checked the source, I saw that the btn variable was only ever set in the if(!attrs.id) block and so the zeroclipboard client was not being created in the case where I was trying to clip to an element with an id.