Add base path option #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
tobbenb
requested changes
Jan 2, 2021
Member
tobbenb
left a comment
tobbenb
left a comment
There was a problem hiding this comment.
Could you move the changelog entry to the top so it's the same as all other README's?
Contributor
|
I am a bot, here are the test results for this PR: |
1 similar comment
Contributor
|
I am a bot, here are the test results for this PR: |
Contributor
Author
|
@tobbenb is that better? |
Contributor
Author
|
Hi. Any updates? |
tobbenb
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7
Description:
Adds
BASE_PATHto the list of environment variables accepted which will populate the variable in configuration.pyBenefits of this PR and context:
Container can be run behind a reverse proxy with a path, eg. https://yourdomain.com/netbox
How Has This Been Tested?
Source / References: