Fix reconnecting when certificate is unchanged #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 70cc5eb Warpinator can no longer reconnect to a rediscovered device after connection was once lost when the certificate is unchanged (remote comes back with the same IP as last time). I have fixed this by adding a condition to also reconnect when certificate is up to date and the remote is offline. The
newly_discoveredflag is to allow reconnect after server restart in which case remotes are cleared, but certificates are not (CERT_UP_TO_DATEandRemoteStatus.INIT_CONNECTING, which on its own could also mean that the remote thread is already running). Another option in this case would be to also clear the certificates on restart.(Sorry about taking so long to finish the text message PR, hopefully I'll get to it soon)