Allow use of base-2 file size prefixes (kiB, MiB, GiB) instead of base-10 #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefebvre
added a commit
that referenced
this pull request
Sep 26, 2012
Allow use of base-2 file size prefixes (kiB, MiB, GiB) instead of base-10
|
Great work. |
daschuer
pushed a commit
to daschuer/nemo
that referenced
this pull request
Sep 26, 2014
Allow use of base-2 file size prefixes (kiB, MiB, GiB) instead of base-10
Closed
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion, a file manager should show file sizes with base-2 prefixes because that's what I care about when I look at file sizes. Even Windows Explorer does this (Although it displays it with MB instead of MiB). Now Nemo is able to use base-2 prefixes, too.
I decided to create 4 enum values out of the possible flags because that way it is not neccessary to struggle with flags in such a simple case.
Implements #13. Display style is configurable under preferences.
However, if you don't want Nemo to be able to use base-2 prefixes (although I hope you do), then just reject this request ;-)