Fix ATC_DST_PER_MSB for sama5d3 #52
Closed
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the upper nibble of interface identifire (id) should put into CFG bits 15 and 14 (ATC_DST_PER_MSB), because the lower four bits are always in bits 3 to 0 (ATC_DST_PER). Same for ATC_SRC_PER_MSB. Typically effect of this bug are loosing charcters on serial output with DMA enabled, because the flow controller would connect with wrong interface.
atdma_sg->len and desc->sg[i].len are the same pointer to variable "len". Only need once.
Sometime was used "atdma_sg->len", other cases was used "desc->sg[i].len". Use same coding style for all settings of descriptor length.
at_hdmac: Always use atdma_sg->len for desc->sg[i].len
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the upper nibble of interface identifire (id) should put into CFG bits 15 and 14 (ATC_DST_PER_MSB), because the lower four bits are always in bits 3 to 0 (ATC_DST_PER). Same for ATC_SRC_PER_MSB.
Typically effect of this bug are loosing charcters on serial output with DMA enabled, because the flow controller would connect with wrong interface.