sam9x60 sip types added to soc description. #46

ksdd · 2020-09-25T15:17:51Z

Hi,

this patch adds the SAM9X60 SIP variants to the soc description list.

alexandrebelloni

Seems good to me, maybe you should also submit that upstream.

alexandrebelloni · 2020-09-25T15:20:48Z

drivers/soc/atmel/soc.c

-		pr_warn("Could not find matching SoC description\n");
+		pr_warn("Could not find matching SoC description"
+			" (cidr %08x, exid %08x)", cidr, exid);
 		return NULL;


This is an unrelated change

Should I revert the change of the warning and probably create a different pull request? It is definitely useful, when running on yet unsupported soc's.

Yes, two separate patches would be the best. However, This will increase the kernel size for a very unusual use case. Most of the time, the soc ids will be present. Maybe use pr_debug ?

BTW, are you actually using this driver for something useful?

I reverted the change of the print and decided not to create a different pull request for it. As You pointed out, it should be of rare use. To be honest, I don't know, what the soc registration is good for. I just stumbled over the ""Could not find matching SoC description" warning in the dmesg and fixed it.

You proposed to submit this change upstream. I guess You mean submitting it to the mainline kernel. I requested the pull to linux-at91, because this is my direct upstream. And I thought, that the linux-at91 maintainers will submit relevant changes further up.

Yes, we can do it.

noglitch · 2020-09-30T13:21:47Z

BTW @ksdd can you add your Signed-off-by: tag to the patch so that I can add it.
You would also need to tell us if you want this S-o-B tag to appear in kernel.org upstream.
Best regards,
Nicolas

noglitch · 2020-09-30T13:23:22Z

drivers/soc/atmel/soc.c

 #ifdef CONFIG_SOC_SAM9X60
 	AT91_SOC(SAM9X60_CIDR_MATCH, SAM9X60_EXID_MATCH, "sam9x60", "sam9x60"),
+	AT91_SOC(SAM9X60_CIDR_MATCH, SAM9X60D5M_EXID_MATCH,
+		 "sam9x60d6m", "sam9x60"),


Take example on sama5d2 SiP lines to have a coherent display between the different SiP products.

ksdd · 2020-10-02T12:16:17Z

Hi @noglitch, I changed the descriptions as You suggested. I hope, it is okay now.

ksdd · 2020-10-02T12:23:08Z

Regarding "Signed-off-by", I am not sure, how to do that for already pushed commits. I could re-base back to branch start and re-commit the changes with S-o-B. But that requires a force push and changes commit history, which should usually be avoided. Is S-o-B really needed?

noglitch · 2020-10-02T12:30:15Z

Well, if you don't manage to add them on the patch (use git commit -s) simply add :
Signed-off-by: name <email@addr>
here and I'll add it to the final patch, no problem

noglitch · 2020-10-02T12:33:20Z

drivers/soc/atmel/soc.c

+		 "sam9x60d5m 512MiB DDR2 SiP", "sam9x60"),
 	AT91_SOC(SAM9X60_CIDR_MATCH, SAM9X60D1G_EXID_MATCH,
-		 "sam9x60d1g", "sam9x60"),
+		 "sam9x60d1g 1GiB DDR2 SiP", "sam9x60"),


Well, no, this is not 1GiB, it's 128MiB: please correct all them.

Bits and bytes - always difficult. I will fix it.

noglitch · 2020-10-02T12:33:50Z

drivers/soc/atmel/soc.c

 #endif
 #ifdef CONFIG_SOC_SAM9X60
 	AT91_SOC(SAM9X60_CIDR_MATCH, SAM9X60_EXID_MATCH, "sam9x60", "sam9x60"),
 	AT91_SOC(SAM9X60_CIDR_MATCH, SAM9X60D5M_EXID_MATCH,


I'd like that the #defines are like the other ones: SAM9X60_D5M_EXID_MATCH

@noglitch : EXID_MATCH definitions changed with commit feff97a.

alexandrebelloni · 2020-10-02T13:05:03Z

You should definitively rebase and squash all those commits and also add your SoB. Rebasing is ok because you don't have any downstream.

ksdd · 2020-10-02T13:10:25Z

@alexandrebelloni : Okay, I will rebase and squash, once @noglitch is happy with the changes.

noglitch · 2020-10-07T11:59:39Z

Patch applied in linux-5.4-at91 branch and master. Thanks a lot Kai for patiently having re-spin this patch.
e60a4f2
Best regards,
Nicolas

[ Upstream commit 3d51794 ] When removing the driver we would hit BUG_ON(!list_empty(&dev->ptype_specific)) in net/core/dev.c due to still having the NC-SI packet handler registered. # echo 1e660000.ethernet > /sys/bus/platform/drivers/ftgmac100/unbind ------------[ cut here ]------------ kernel BUG at net/core/dev.c:10254! Internal error: Oops - BUG: 0 [#1] SMP ARM CPU: 0 PID: 115 Comm: sh Not tainted 5.10.0-rc3-next-20201111-00007-g02e0365710c4 #46 Hardware name: Generic DT based system PC is at netdev_run_todo+0x314/0x394 LR is at cpumask_next+0x20/0x24 pc : [<806f5830>] lr : [<80863cb0>] psr: 80000153 sp : 855bbd58 ip : 00000001 fp : 855bbdac r10: 80c03d00 r9 : 80c06228 r8 : 81158c54 r7 : 00000000 r6 : 80c05dec r5 : 80c05d18 r4 : 813b9280 r3 : 813b9054 r2 : 8122c470 r1 : 00000002 r0 : 00000002 Flags: Nzcv IRQs on FIQs off Mode SVC_32 ISA ARM Segment none Control: 00c5387d Table: 85514008 DAC: 00000051 Process sh (pid: 115, stack limit = 0x7cb5703d) ... Backtrace: [<806f551c>] (netdev_run_todo) from [<80707eec>] (rtnl_unlock+0x18/0x1c) r10:00000051 r9:854ed710 r8:81158c54 r7:80c76bb0 r6:81158c10 r5:8115b410 r4:813b9000 [<80707ed4>] (rtnl_unlock) from [<806f5db8>] (unregister_netdev+0x2c/0x30) [<806f5d8c>] (unregister_netdev) from [<805a8180>] (ftgmac100_remove+0x20/0xa8) r5:8115b410 r4:813b9000 [<805a8160>] (ftgmac100_remove) from [<805355e4>] (platform_drv_remove+0x34/0x4c) Fixes: bd466c3 ("net/faraday: Support NCSI mode") Signed-off-by: Joel Stanley <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>

commit 7c6986a upstream. In raise_backtrace_ipi() we iterate through the cpumask of CPUs, sending each an IPI asking them to do a backtrace, but we don't wait for the backtrace to happen. We then iterate through the CPU mask again, and if any CPU hasn't done the backtrace and cleared itself from the mask, we print a trace on its behalf, noting that the trace may be "stale". This works well enough when a CPU is not responding, because in that case it doesn't receive the IPI and the sending CPU is left to print the trace. But when all CPUs are responding we are left with a race between the sending and receiving CPUs, if the sending CPU wins the race then it will erroneously print a trace. This leads to spurious "stale" traces from the sending CPU, which can then be interleaved messily with the receiving CPU, note the CPU numbers, eg: [ 1658.929157][ C7] rcu: Stack dump where RCU GP kthread last ran: [ 1658.929223][ C7] Sending NMI from CPU 7 to CPUs 1: [ 1658.929303][ C1] NMI backtrace for cpu 1 [ 1658.929303][ C7] CPU 1 didn't respond to backtrace IPI, inspecting paca. [ 1658.929362][ C1] CPU: 1 PID: 325 Comm: kworker/1:1H Tainted: G W E 5.13.0-rc2+ #46 [ 1658.929405][ C7] irq_soft_mask: 0x01 in_mce: 0 in_nmi: 0 current: 325 (kworker/1:1H) [ 1658.929465][ C1] Workqueue: events_highpri test_work_fn [test_lockup] [ 1658.929549][ C7] Back trace of paca->saved_r1 (0xc0000000057fb400) (possibly stale): [ 1658.929592][ C1] NIP: c00000000002cf50 LR: c008000000820178 CTR: c00000000002cfa0 To fix it, change the logic so that the sending CPU waits 5s for the receiving CPU to print its trace. If the receiving CPU prints its trace successfully then the sending CPU just continues, avoiding any spurious "stale" trace. This has the added benefit of allowing all CPUs to print their traces in order and avoids any interleaving of their output. Fixes: 5cc0591 ("powerpc/64s: Wire up arch_trigger_cpumask_backtrace()") Cc: [email protected] # v4.18+ Reported-by: Nathan Lynch <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

In case of fixed link devices the mdiodev in mdio_device_reset() is null leading to the following crash: 8<--- cut here --- Unable to handle kernel NULL pointer dereference at virtual address 000001f0 [000001f0] *pgd=00000000 Internal error: Oops: 5 [#1] ARM Modules linked in: tag_ksz ksz_spi ksz_switch dsa_core bridge stp llc microchip lan78xx atmel_usba_udc CPU: 0 PID: 249 Comm: sh Not tainted 6.1.22-linux4microchip-2023.04-rc1+ #46 Hardware name: Atmel SAMA5 PC is at mdio_device_reset+0x8/0x9c LR is at phy_init_hw+0x10/0xa4 pc : [<c058f1a8>] lr : [<c058cbd0>] psr: 600b0013 sp : e0b61d80 ip : 00000100 fp : c0ab43cc r10: c0d92d50 r9 : 00000100 r8 : c13d1000 r7 : c13d0520 r6 : c13d1c0c r5 : c13d0000 r4 : 00000000 r3 : c1ad4440 r2 : 00000000 r1 : 00000000 r0 : 00000000 Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none Control: 10c53c7d Table: 21b20059 DAC: 00000051 Register r0 information: NULL pointer Register r1 information: NULL pointer Register r2 information: NULL pointer Register r3 information: slab task_struct start c1ad4440 pointer offset 0 Register r4 information: NULL pointer Register r5 information: slab kmalloc-cg-8k start c13d0000 pointer offset 0 size 8192 Register r6 information: slab kmalloc-cg-8k start c13d0000 pointer offset 7180 size 8192 Register r7 information: slab kmalloc-cg-8k start c13d0000 pointer offset 1312 size 8192 Register r8 information: slab kmalloc-cg-8k start c13d0000 pointer offset 4096 size 8192 Register r9 information: non-paged memory Register r10 information: non-slab/vmalloc memory Register r11 information: non-slab/vmalloc memory Register r12 information: non-paged memory Process sh (pid: 249, stack limit = 0x74d3815e) Stack: (0xe0b61d80 to 0xe0b62000) 1d80: 00000000 c13d0000 c13d1c0c c058cbd0 c13d1b64 c059d098 e0b61d90 00000006 1da0: e0b61dc0 c04fdbc0 c1056c10 c04fdbc0 c1056c10 c0d71eec 00000010 b66d215e 1dc0: 00000006 c0509e84 c1056c10 c0d5300c c1056c50 00000001 c1056c10 00000000 1de0: 00000010 c1056c54 00000010 c050a8b4 c1056c8c c0d52fe8 c1056c10 c0d52fe8 1e00: c0d5300c c050b4d8 00000010 c050b33c 931f958c 00000006 8eff9f7e 00000006 1e20: c0aeb4cc 00000010 00000001 00000002 00000000 c0d032b8 c0d0c6a4 00000000 1e40: c0d71ef0 c050b7d0 c0d71f04 c01483c0 c0aab0c4 c1ad4440 c0d03240 c0d032b0 1e60: 0056c190 c014bf68 e0b61e8c 29aa0439 c1ad4440 00000000 00000002 c0d032b0 1e80: c0aab0c4 00000008 c1bae640 c28c5110 0056c190 c0148928 00000002 c0adae58 1ea0: 00000007 c0d71f18 00000008 c0147378 00000008 c28c5100 00000000 00000000 1ec0: c1bae640 e0b61f28 c28c5110 c0262340 00000000 00000000 c1c0a600 c1ad4440 1ee0: 0056ebc8 00000008 c0908ac8 00004004 00000000 c01ee76c c290ea80 c1ad4440 1f00: c290ea80 0000000a 0000000a e0b61f78 0101000 00000008 00000000 0056ebc8 1f20: 00000000 00000000 c1c0a600 00000000 00000000 00000000 00000000 00000000 1f40: 00000000 00004004 00000000 00000000 00000001 29aa0439 c1c0a600 c1c0a600 1f60: 00000000 00000000 c1ad4440 0056ebc8 00000008 c01ee998 00000000 00000000 1f80: 00000000 29aa0439 00000001 00000000 b6f54480 00000004 c01002c0 c1ad4440 1fa0: 00000004 c0100060 00000001 00000000 00000001 0056ebc8 00000008 00000000 1fc0: 00000001 00000000 b6f54480 00000004 00000008 bed176c0 00000020 0056c190 1fe0: 00000004 bed17670 b6e675c7 b6dea9b6 60000030 00000001 00000000 00000000 mdio_device_reset from phy_init_hw+0x10/0xa4 phy_init_hw from macb_resume+0x2ac/0x358 macb_resume from dpm_run_callback.constprop.8+0x3c/0xbc dpm_run_callback.constprop.8 from device_resume+0xa4/0x17c device_resume from dpm_resume+0xd0/0x200 dpm_resume from dpm_resume_end+0xc/0x18 dpm_resume_end from suspend_devices_and_enter+0x2a4/0x5e4 suspend_devices_and_enter from pm_suspend+0x228/0x338 pm_suspend from state_store+0x6c/0xc8 state_store from kernfs_fop_write_iter+0x118/0x1b4 kernfs_fop_write_iter from vfs_write+0x294/0x34c vfs_write from ksys_write+0xa0/0xd0 ksys_write from ret_fast_syscall+0x0/0x54 Exception stack(0xe0b61fa8 to 0xe0b61ff0) 1fa0: 00000001 00000000 00000001 0056ebc8 00000008 00000000 1fc0: 00000001 00000000 b6f54480 00000004 00000008 bed176c0 00000020 0056c190 1fe0: 00000004 bed17670 b6e675c7 b6dea9b6 Code: e8bd4010 eafffc6 e92d4070 e1a04000 (e59001f0) ---[ end trace 0000000000000000 ]--- Fixes: e0bc931 ("net: macb: fix ethernet after resume") Fixes: 15a9dbe ("net: macb: Specify PHY PM management done by MAC") Signed-off-by: Claudiu Beznea <[email protected]>

In case of fixed link devices the mdiodev in mdio_device_reset() is null leading to the following crash: 8<--- cut here --- Unable to handle kernel NULL pointer dereference at virtual address 000001f0 [000001f0] *pgd=00000000 Internal error: Oops: 5 [#1] ARM Modules linked in: tag_ksz ksz_spi ksz_switch dsa_core bridge stp llc microchip lan78xx atmel_usba_udc CPU: 0 PID: 249 Comm: sh Not tainted 6.1.22-linux4microchip-2023.04-rc1+ #46 Hardware name: Atmel SAMA5 PC is at mdio_device_reset+0x8/0x9c LR is at phy_init_hw+0x10/0xa4 pc : [<c058f1a8>] lr : [<c058cbd0>] psr: 600b0013 sp : e0b61d80 ip : 00000100 fp : c0ab43cc r10: c0d92d50 r9 : 00000100 r8 : c13d1000 r7 : c13d0520 r6 : c13d1c0c r5 : c13d0000 r4 : 00000000 r3 : c1ad4440 r2 : 00000000 r1 : 00000000 r0 : 00000000 Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none Control: 10c53c7d Table: 21b20059 DAC: 00000051 Register r0 information: NULL pointer Register r1 information: NULL pointer Register r2 information: NULL pointer Register r3 information: slab task_struct start c1ad4440 pointer offset 0 Register r4 information: NULL pointer Register r5 information: slab kmalloc-cg-8k start c13d0000 pointer offset 0 size 8192 Register r6 information: slab kmalloc-cg-8k start c13d0000 pointer offset 7180 size 8192 Register r7 information: slab kmalloc-cg-8k start c13d0000 pointer offset 1312 size 8192 Register r8 information: slab kmalloc-cg-8k start c13d0000 pointer offset 4096 size 8192 Register r9 information: non-paged memory Register r10 information: non-slab/vmalloc memory Register r11 information: non-slab/vmalloc memory Register r12 information: non-paged memory Process sh (pid: 249, stack limit = 0x74d3815e) Stack: (0xe0b61d80 to 0xe0b62000) 1d80: 00000000 c13d0000 c13d1c0c c058cbd0 c13d1b64 c059d098 e0b61d90 00000006 1da0: e0b61dc0 c04fdbc0 c1056c10 c04fdbc0 c1056c10 c0d71eec 00000010 b66d215e 1dc0: 00000006 c0509e84 c1056c10 c0d5300c c1056c50 00000001 c1056c10 00000000 1de0: 00000010 c1056c54 00000010 c050a8b4 c1056c8c c0d52fe8 c1056c10 c0d52fe8 1e00: c0d5300c c050b4d8 00000010 c050b33c 931f958c 00000006 8eff9f7e 00000006 1e20: c0aeb4cc 00000010 00000001 00000002 00000000 c0d032b8 c0d0c6a4 00000000 1e40: c0d71ef0 c050b7d0 c0d71f04 c01483c0 c0aab0c4 c1ad4440 c0d03240 c0d032b0 1e60: 0056c190 c014bf68 e0b61e8c 29aa0439 c1ad4440 00000000 00000002 c0d032b0 1e80: c0aab0c4 00000008 c1bae640 c28c5110 0056c190 c0148928 00000002 c0adae58 1ea0: 00000007 c0d71f18 00000008 c0147378 00000008 c28c5100 00000000 00000000 1ec0: c1bae640 e0b61f28 c28c5110 c0262340 00000000 00000000 c1c0a600 c1ad4440 1ee0: 0056ebc8 00000008 c0908ac8 00004004 00000000 c01ee76c c290ea80 c1ad4440 1f00: c290ea80 0000000a 0000000a e0b61f78 0101000 00000008 00000000 0056ebc8 1f20: 00000000 00000000 c1c0a600 00000000 00000000 00000000 00000000 00000000 1f40: 00000000 00004004 00000000 00000000 00000001 29aa0439 c1c0a600 c1c0a600 1f60: 00000000 00000000 c1ad4440 0056ebc8 00000008 c01ee998 00000000 00000000 1f80: 00000000 29aa0439 00000001 00000000 b6f54480 00000004 c01002c0 c1ad4440 1fa0: 00000004 c0100060 00000001 00000000 00000001 0056ebc8 00000008 00000000 1fc0: 00000001 00000000 b6f54480 00000004 00000008 bed176c0 00000020 0056c190 1fe0: 00000004 bed17670 b6e675c7 b6dea9b6 60000030 00000001 00000000 00000000 mdio_device_reset from phy_init_hw+0x10/0xa4 phy_init_hw from macb_resume+0x2ac/0x358 macb_resume from dpm_run_callback.constprop.8+0x3c/0xbc dpm_run_callback.constprop.8 from device_resume+0xa4/0x17c device_resume from dpm_resume+0xd0/0x200 dpm_resume from dpm_resume_end+0xc/0x18 dpm_resume_end from suspend_devices_and_enter+0x2a4/0x5e4 suspend_devices_and_enter from pm_suspend+0x228/0x338 pm_suspend from state_store+0x6c/0xc8 state_store from kernfs_fop_write_iter+0x118/0x1b4 kernfs_fop_write_iter from vfs_write+0x294/0x34c vfs_write from ksys_write+0xa0/0xd0 ksys_write from ret_fast_syscall+0x0/0x54 Exception stack(0xe0b61fa8 to 0xe0b61ff0) 1fa0: 00000001 00000000 00000001 0056ebc8 00000008 00000000 1fc0: 00000001 00000000 b6f54480 00000004 00000008 bed176c0 00000020 0056c190 1fe0: 00000004 bed17670 b6e675c7 b6dea9b6 Code: e8bd4010 eafffc6 e92d4070 e1a04000 (e59001f0) ---[ end trace 0000000000000000 ]--- Fixes: e0bc931 ("net: macb: fix ethernet after resume") Fixes: 15a9dbe ("net: macb: Specify PHY PM management done by MAC") Signed-off-by: Claudiu Beznea <[email protected]>>

In case of fixed link devices the mdiodev in mdio_device_reset() is null leading to the following crash: 8<--- cut here --- Unable to handle kernel NULL pointer dereference at virtual address 000001f0 [000001f0] *pgd=00000000 Internal error: Oops: 5 [#1] ARM Modules linked in: tag_ksz ksz_spi ksz_switch dsa_core bridge stp llc microchip lan78xx atmel_usba_udc CPU: 0 PID: 249 Comm: sh Not tainted 6.1.22-linux4microchip-2023.04-rc1+ #46 Hardware name: Atmel SAMA5 PC is at mdio_device_reset+0x8/0x9c LR is at phy_init_hw+0x10/0xa4 pc : [<c058f1a8>] lr : [<c058cbd0>] psr: 600b0013 sp : e0b61d80 ip : 00000100 fp : c0ab43cc r10: c0d92d50 r9 : 00000100 r8 : c13d1000 r7 : c13d0520 r6 : c13d1c0c r5 : c13d0000 r4 : 00000000 r3 : c1ad4440 r2 : 00000000 r1 : 00000000 r0 : 00000000 Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none Control: 10c53c7d Table: 21b20059 DAC: 00000051 Register r0 information: NULL pointer Register r1 information: NULL pointer Register r2 information: NULL pointer Register r3 information: slab task_struct start c1ad4440 pointer offset 0 Register r4 information: NULL pointer Register r5 information: slab kmalloc-cg-8k start c13d0000 pointer offset 0 size 8192 Register r6 information: slab kmalloc-cg-8k start c13d0000 pointer offset 7180 size 8192 Register r7 information: slab kmalloc-cg-8k start c13d0000 pointer offset 1312 size 8192 Register r8 information: slab kmalloc-cg-8k start c13d0000 pointer offset 4096 size 8192 Register r9 information: non-paged memory Register r10 information: non-slab/vmalloc memory Register r11 information: non-slab/vmalloc memory Register r12 information: non-paged memory Process sh (pid: 249, stack limit = 0x74d3815e) Stack: (0xe0b61d80 to 0xe0b62000) 1d80: 00000000 c13d0000 c13d1c0c c058cbd0 c13d1b64 c059d098 e0b61d90 00000006 1da0: e0b61dc0 c04fdbc0 c1056c10 c04fdbc0 c1056c10 c0d71eec 00000010 b66d215e 1dc0: 00000006 c0509e84 c1056c10 c0d5300c c1056c50 00000001 c1056c10 00000000 1de0: 00000010 c1056c54 00000010 c050a8b4 c1056c8c c0d52fe8 c1056c10 c0d52fe8 1e00: c0d5300c c050b4d8 00000010 c050b33c 931f958c 00000006 8eff9f7e 00000006 1e20: c0aeb4cc 00000010 00000001 00000002 00000000 c0d032b8 c0d0c6a4 00000000 1e40: c0d71ef0 c050b7d0 c0d71f04 c01483c0 c0aab0c4 c1ad4440 c0d03240 c0d032b0 1e60: 0056c190 c014bf68 e0b61e8c 29aa0439 c1ad4440 00000000 00000002 c0d032b0 1e80: c0aab0c4 00000008 c1bae640 c28c5110 0056c190 c0148928 00000002 c0adae58 1ea0: 00000007 c0d71f18 00000008 c0147378 00000008 c28c5100 00000000 00000000 1ec0: c1bae640 e0b61f28 c28c5110 c0262340 00000000 00000000 c1c0a600 c1ad4440 1ee0: 0056ebc8 00000008 c0908ac8 00004004 00000000 c01ee76c c290ea80 c1ad4440 1f00: c290ea80 0000000a 0000000a e0b61f78 0101000 00000008 00000000 0056ebc8 1f20: 00000000 00000000 c1c0a600 00000000 00000000 00000000 00000000 00000000 1f40: 00000000 00004004 00000000 00000000 00000001 29aa0439 c1c0a600 c1c0a600 1f60: 00000000 00000000 c1ad4440 0056ebc8 00000008 c01ee998 00000000 00000000 1f80: 00000000 29aa0439 00000001 00000000 b6f54480 00000004 c01002c0 c1ad4440 1fa0: 00000004 c0100060 00000001 00000000 00000001 0056ebc8 00000008 00000000 1fc0: 00000001 00000000 b6f54480 00000004 00000008 bed176c0 00000020 0056c190 1fe0: 00000004 bed17670 b6e675c7 b6dea9b6 60000030 00000001 00000000 00000000 mdio_device_reset from phy_init_hw+0x10/0xa4 phy_init_hw from macb_resume+0x2ac/0x358 macb_resume from dpm_run_callback.constprop.8+0x3c/0xbc dpm_run_callback.constprop.8 from device_resume+0xa4/0x17c device_resume from dpm_resume+0xd0/0x200 dpm_resume from dpm_resume_end+0xc/0x18 dpm_resume_end from suspend_devices_and_enter+0x2a4/0x5e4 suspend_devices_and_enter from pm_suspend+0x228/0x338 pm_suspend from state_store+0x6c/0xc8 state_store from kernfs_fop_write_iter+0x118/0x1b4 kernfs_fop_write_iter from vfs_write+0x294/0x34c vfs_write from ksys_write+0xa0/0xd0 ksys_write from ret_fast_syscall+0x0/0x54 Exception stack(0xe0b61fa8 to 0xe0b61ff0) 1fa0: 00000001 00000000 00000001 0056ebc8 00000008 00000000 1fc0: 00000001 00000000 b6f54480 00000004 00000008 bed176c0 00000020 0056c190 1fe0: 00000004 bed17670 b6e675c7 b6dea9b6 Code: e8bd4010 eafffc6 e92d4070 e1a04000 (e59001f0) ---[ end trace 0000000000000000 ]--- Fixes: e0bc931 ("net: macb: fix ethernet after resume") Fixes: 15a9dbe ("net: macb: Specify PHY PM management done by MAC") Signed-off-by: Claudiu Beznea <[email protected]>> (cherry picked from linux-6.6-trunk/at91/net) Signed-off-by: Andrei Simion <[email protected]>

sam9x60 sip types added to soc description.

8c30170

alexandrebelloni reviewed Sep 25, 2020

View reviewed changes

Unrelated change reverted.

7f38ed4

noglitch requested changes Sep 30, 2020

View reviewed changes

sam9x60 sip type descriptions corrected.

ab87417

ksdd requested a review from noglitch October 2, 2020 12:23

noglitch requested changes Oct 2, 2020

View reviewed changes

Corrected sam9x60 sip size values in description.

b5af97f

ksdd requested a review from noglitch October 2, 2020 12:57

Naming scheme of sam9x60 sip exid definitions fixed.

feff97a

noglitch closed this Oct 7, 2020

Uh oh!

sam9x60 sip types added to soc description. #46

sam9x60 sip types added to soc description. #46

Uh oh!

Conversation

ksdd commented Sep 25, 2020

Uh oh!

alexandrebelloni left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

noglitch commented Sep 30, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ksdd commented Oct 2, 2020

Uh oh!

ksdd commented Oct 2, 2020

Uh oh!

noglitch commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexandrebelloni commented Oct 2, 2020

Uh oh!

ksdd commented Oct 2, 2020

Uh oh!

noglitch commented Oct 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

noglitch commented Oct 2, 2020 •

edited

Loading