Skip to content

feat: Smaller ui adjustments for short card #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2025
Merged

feat: Smaller ui adjustments for short card #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/LinkDotNet.Blog.Web/Features/Components/ShortBlogPost.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
</div>
<div class="description">
<div class="header">
<h1>@BlogPost.Title</h1>
<h4 class="card-title">@BlogPost.Title</h4>
<BookmarkButton IsBookmarked="isBookmarked" Bookmarked="ToggleBookmark"></BookmarkButton>
</div>
<p>@MarkdownConverter.ToMarkupString(BlogPost.ShortDescription)</p>
<p class="card-content">@MarkdownConverter.ToMarkupString(BlogPost.ShortDescription)</p>
<p class="read-more">
<a href="/blogPost/@BlogPost.Id/@BlogPost.Slug" aria-label="@BlogPost.Title">Read the whole article</a>
</p>
Expand Down
18 changes: 9 additions & 9 deletions src/LinkDotNet.Blog.Web/Features/Components/ShortBlogPost.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,6 @@
justify-content: space-between;
}

.blog-card .description h1 {
line-height: 1;
margin: 0 0 5px 0;
font-size: 1.7rem;
}
.blog-card .description .read-more {
text-align: right;
}
Expand Down Expand Up @@ -155,11 +150,16 @@
background-color: #ff8700;
}

@media (max-width: 400px) {
.blog-card .description h1 {
font-size: 1.25rem;
}
.card-title {
font-weight: 600;
line-height: 1.3;
margin-right: 1rem;
}

.card-content {
font-weight: 300;
}

@media (min-width: 640px) {
.blog-card {
flex-direction: row;
Expand Down
2 changes: 1 addition & 1 deletion ...nkDotNet.Blog.IntegrationTests/Web/Features/Admin/DraftBlogPost/DraftBlogPostPageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ public async Task ShouldOnlyShowPublishedPosts()
var blogPosts = cut.FindComponents<ShortBlogPost>();

blogPosts.ShouldHaveSingleItem();
blogPosts[0].Find(".description h1").InnerHtml.ShouldBe("Not published");
blogPosts[0].Find(".description h4").InnerHtml.ShouldBe("Not published");
}
}
2 changes: 1 addition & 1 deletion tests/LinkDotNet.Blog.IntegrationTests/Web/Features/Bookmarks/BookmarksTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public async Task ShouldOnlyDisplayBookmarkedPosts()
var blogPosts = cut.FindComponents<ShortBlogPost>();

blogPosts.ShouldHaveSingleItem();
blogPosts[0].Find(".description h1").TextContent.ShouldBe("Bookmarked Post");
blogPosts[0].Find(".description h4").TextContent.ShouldBe("Bookmarked Post");
}

[Fact]
Expand Down
6 changes: 3 additions & 3 deletions tests/LinkDotNet.Blog.IntegrationTests/Web/Features/Home/IndexTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ public async Task ShouldShowAllBlogPostsWithLatestOneFirst()
var blogPosts = cut.FindComponents<ShortBlogPost>();

blogPosts.Count.ShouldBe(2);
blogPosts[0].Find(".description h1").InnerHtml.ShouldBe("New");
blogPosts[1].Find(".description h1").InnerHtml.ShouldBe("Old");
blogPosts[0].Find(".description h4").InnerHtml.ShouldBe("New");
blogPosts[1].Find(".description h4").InnerHtml.ShouldBe("Old");
}

[Fact]
Expand All @@ -50,7 +50,7 @@ public async Task ShouldOnlyShowPublishedPosts()
var blogPosts = cut.FindComponents<ShortBlogPost>();

blogPosts.ShouldHaveSingleItem();
blogPosts[0].Find(".description h1").InnerHtml.ShouldBe("Published");
blogPosts[0].Find(".description h4").InnerHtml.ShouldBe("Published");
}

[Fact]
Expand Down
6 changes: 3 additions & 3 deletions tests/LinkDotNet.Blog.IntegrationTests/Web/Features/Search/SearchPageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public async Task ShouldFindBlogPostWhenTitleMatches()
var cut = ctx.Render<SearchPage>(p => p.Add(s => s.SearchTerm, "Title 1"));

var blogPosts = cut.WaitForComponent<ShortBlogPost>();
blogPosts.Find(".description h1").TextContent.ShouldBe("Title 1");
blogPosts.Find(".description h4").TextContent.ShouldBe("Title 1");
}

[Fact]
Expand All @@ -39,7 +39,7 @@ public async Task ShouldFindBlogPostWhenTagMatches()
var cut = ctx.Render<SearchPage>(p => p.Add(s => s.SearchTerm, "Cat"));

var blogPost = cut.WaitForComponent<ShortBlogPost>();
blogPost.Find(".description h1").TextContent.ShouldBe("Title 1");
blogPost.Find(".description h4").TextContent.ShouldBe("Title 1");
}

[Fact]
Expand All @@ -53,7 +53,7 @@ public async Task ShouldUnescapeQuery()
var cut = ctx.Render<SearchPage>(p => p.Add(s => s.SearchTerm, "Title%201"));

var blogPosts = cut.WaitForComponent<ShortBlogPost>();
blogPosts.Find(".description h1").TextContent.ShouldBe("Title 1");
blogPosts.Find(".description h4").TextContent.ShouldBe("Title 1");
}

private void RegisterServices(BunitContext ctx)
Expand Down