Require more jobs in merge queue #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eucyt
approved these changes
Apr 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Thank you for the review. It seems to fail at the part where line-openapi is injected into other SDK repositories. |
Yang-33
commented
Apr 7, 2025
Comment on lines
-22
to
-30
| run: | | ||
| cd line-openapi | ||
| git remote add pr-source $PR_REPO_URL | ||
| git fetch pr-source $PR_REF | ||
| git checkout FETCH_HEAD | ||
| env: | ||
| PR_REPO_URL: ${{ github.event.pull_request.head.repo.clone_url }} | ||
| PR_REF: ${{ github.event.pull_request.head.ref }} |
Contributor
Author
There was a problem hiding this comment.
This is a way to make it work only when pull request. This change fixes the checkout way so that it always works as expected.
JAVAYou can check generated code in java |
PHPYou can check generated code in php |
NODEJSYou can check generated code in nodejs |
GOYou can check generated code in go |
PYTHONYou can check generated code in python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To re-enable the merge queue, this change adds merge_group to several jobs.
original: line/line-bot-sdk-java#1592
Additionally, by using actions/checkout, this change modifies how to inject the latest openapi schema so that the bot SDK tests always run with the latest line-openapi, even outside of PRs. This will be a safer approach.