Skip to content

Conversation

@Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Mar 26, 2025

Changes

Granting the minimum necessary permissions is always a good practice. There might be cases where permissions are insufficient, but since errors are very clear, I believe we can add them when a failure occurs.

After merging, I will change the default of the GITHUB_ACTIONS token from read + write to read only. Then, I will run as many workflows as possible (including publish) to verify their operation.

reference: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token#overview

parent: line/line-bot-sdk-nodejs#1202

@Yang-33 Yang-33 self-assigned this Mar 26, 2025
@Yang-33 Yang-33 requested a review from a team March 26, 2025 14:33
@Yang-33 Yang-33 merged commit 2309203 into line:master Mar 27, 2025
13 checks passed
@Yang-33 Yang-33 deleted the grant-minimum-permissions branch March 27, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants