Skip to content

Conversation

@habara-k
Copy link
Contributor

@habara-k habara-k commented Feb 7, 2025

This PR addresses the issue of potential breaking changes in our dependencies by freezing the current package versions in the requirements-*.txt files.

@habara-k habara-k requested review from a team and mokuzon February 25, 2025 06:51
requirements.txt Outdated
Comment on lines 1 to 8
requests>=2.32.3,<3
urllib3>=2.0.5,<3
aiohttp >=3.10.9
future
aiohttp >=3.10.9, <4
future==1.0.0
pydantic >=2.0.3, <3
aenum >= 3.1.11
python_dateutil >= 2.5.3
Deprecated
aenum >= 3.1.11, <4
python_dateutil >= 2.5.3, <3
Deprecated==1.2.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about future, Deprecated

If this completely fixes the version, it may cause conflicts with other libraries on the user's side, and the user may not be able to apply security patches. Please only set upper and lower bounds if necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated>=1.2.18
future >= 1.0.0

@habara-k habara-k self-assigned this Mar 12, 2025
@habara-k habara-k requested a review from Yang-33 March 13, 2025 07:31
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you resolve conflict at first?

@habara-k habara-k requested a review from eucyt March 25, 2025 08:53
@Yang-33 Yang-33 merged commit 0cb4bbf into master Mar 26, 2025
22 checks passed
@Yang-33 Yang-33 deleted the users/habara-keigo/fix/freeze-package-versions branch March 26, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants