Skip to content

Conversation

olamilekan000
Copy link
Contributor

change fixes copy command examples formatting in the docs.

@olamilekan000 olamilekan000 force-pushed the fix-copy-cmd-title-docs branch 2 times, most recently from 2a1e16b to a85485f Compare October 2, 2025 11:35
Signed-off-by: olalekan odukoya <[email protected]>
@olamilekan000 olamilekan000 force-pushed the fix-copy-cmd-title-docs branch from a85485f to cac8909 Compare October 2, 2025 11:37
limactl copy file1.txt file2.txt default:/tmp/
#### Copy multiple files
limactl copy file1.txt file2.txt default:/tmp/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of --help isn't expected to be markdown.

The rendering issue should be better resolved in https://github.com/lima-vm/lima/blob/master/cmd/limactl/gendoc.go

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could wrap the whole help text in a code block, but that would not be so easy to read either?

But escaping the newlines and the # characters would be nice, so that they are not mis-interpreted...

Copy link
Member

@afbjorklund afbjorklund Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this: (line breaks with two spaces before newline , escape the comments with \#)


Backends:
auto - Automatically selects the best available backend (rsync preferred, falls back to scp)
rsync - Uses rsync for faster transfers with resume capability (requires rsync on both host and guest)
scp - Uses scp for reliable transfers (always available)

Examples:
# Copy file from guest to host (auto backend)
limactl copy default:/etc/os-release .


Instead of this: https://lima-vm.io/docs/reference/limactl_copy/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@afbjorklund afbjorklund Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the markdown, I found out that the examples were in the wrong place (or it would have been escaped automatically)... But it is still good to fix the output of other commands, to escape the markdown.

Copy link
Contributor Author

@olamilekan000 olamilekan000 Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seeing that the intension behind this PR has been adressed. Thanks @afbjorklund
I'll be closing this.

Copy link
Member

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to escape the generated markdown, to match the text (in help and man)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants