guestagent: reuse netlink connections #4117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `pkg/guestagent/sockets` opened and closed a netlink connection on each invocation of `sockets.List()`. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
guestagent-reuse-netlink-conn
branch
from
5807253 to
a83ea45
Compare
Member
Author
|
@lima-vm/committers Let's merge this to unblock the alpha2 release 🙏 |
jandubois
approved these changes
Oct 3, 2025
Member
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
Thanks, LGTM
My only concern is if this new approach is less robust. Previously a transient failure only affected a single request. Now it can be permanent if clearing the failure state requires closing and reopening the socket.
However, I have no idea how likely a failure is at all, so maybe this is misplaced. The improved efficiency is obviously desirable.
Member
I'm not sure why this was blocking the release; it seems purely like an optimization that should not be user visible. But I guess getting some more testing done before the release will be worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
pkg/guestagent/socketsopened and closed a netlink connection on each invocation ofsockets.List().