Skip to content

Conversation

olamilekan000
Copy link
Contributor

@olamilekan000 olamilekan000 commented Sep 26, 2025

change improves the flexibility of the limactl shell command when used with the 
--preserve-env flag by validating environment variable patterns to only 
allow alphanumeric characters and underscores also allowing 
more flexible environment variable filtering.

Fixes
#4036

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is not clear to explain what is improved

@olamilekan000 olamilekan000 force-pushed the improve-flexibitlty-of-shell branch 4 times, most recently from f570e72 to 3905a98 Compare September 26, 2025 21:57
@olamilekan000 olamilekan000 force-pushed the improve-flexibitlty-of-shell branch from 3905a98 to 2288670 Compare September 27, 2025 09:14
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually run the code, but from reading the changes, it doesn't look like it implements the modified allow list semantics.

It is also missing tests for the changes.

@olamilekan000 olamilekan000 force-pushed the improve-flexibitlty-of-shell branch 2 times, most recently from bef31a5 to deeae2d Compare September 30, 2025 20:56
@jandubois
Copy link
Member

Please run your tests before pushing to the PR:

--- FAIL: TestFilterEnvironment (0.00s)
    --- FAIL: TestFilterEnvironment/allowlist (0.00s)
        envutil_test.go:173: assertion failed: 9 (int) != 2 (int)
FAIL
FAIL	github.com/lima-vm/lima/v2/pkg/envutil	0.188s

@olamilekan000 olamilekan000 force-pushed the improve-flexibitlty-of-shell branch 3 times, most recently from 8ec3ecc to 8428142 Compare September 30, 2025 21:40
@olamilekan000 olamilekan000 force-pushed the improve-flexibitlty-of-shell branch 5 times, most recently from 28c7581 to 1907080 Compare October 1, 2025 19:43
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests need another round of simplification.

@olamilekan000 olamilekan000 force-pushed the improve-flexibitlty-of-shell branch from 1907080 to c7f611f Compare October 5, 2025 06:44
@olamilekan000 olamilekan000 force-pushed the improve-flexibitlty-of-shell branch from c7f611f to 2120deb Compare October 5, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants