-
Notifications
You must be signed in to change notification settings - Fork 705
improve flexibility of limactl shell cmd #4101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
improve flexibility of limactl shell cmd #4101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description is not clear to explain what is improved
f570e72
to
3905a98
Compare
3905a98
to
2288670
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually run the code, but from reading the changes, it doesn't look like it implements the modified allow list semantics.
It is also missing tests for the changes.
bef31a5
to
deeae2d
Compare
Please run your tests before pushing to the PR:
|
8ec3ecc
to
8428142
Compare
28c7581
to
1907080
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tests need another round of simplification.
1907080
to
c7f611f
Compare
Signed-off-by: olalekan odukoya <[email protected]>
c7f611f
to
2120deb
Compare
Fixes
#4036