Use driver feature instead of checking the name

[afbjorklund]

Other container drivers with dynamic addresses and static ports also want to set the port after start.

This means that we have to provide their names too in "limatype", instead of making it fully external.

if *inst.Config.VMType == limatype.WSL2 || *inst.Config.VMType == limatype.AC || *inst.Config.VMType == limatype.DC

There is some weird hard-coded path handling left, that could be the topic of another PR perhaps?

[afbjorklund]

There is a chicken-and-egg problem here, where the driver must be provided with a host port on creation...

Even though it is ignored, and then replaced with the real address and port as a side-effect of InspectStatus

[unsuman]

There is a chicken-and-egg problem here, where the driver must be provided with a host port on creation...

Yes, I tried to tackle this in #3901, but was unable to do so due to time constraints. What are the possible ways to tackle this? 🤔
Earlier, I tried to first configure a driver with the port from the determineSSHLocalPort() func and then if the driver possessed the dynamicSSHAddress then we would have to create the driver once again

[afbjorklund]

Another problem is that the ssh.config is written with the dummy response, so it remains at 127.0.0.1:22 forever.

So while the instance is updated, and limactl ls and limactl shell work, you can't use plain ssh to connect to it.

[afbjorklund]

We will need to fix the issues with "no-op and side-effects" driver API and the address/port allocation separately.

• Restore DynamicSSHAddress functionality for WSL2 #3988

[AkihiroSuda]

WSL2 CI failing

[AkihiroSuda]

For consistency with DynamicSSHAddress, can we invert the logic and make this DynamicSSHPort ?

[afbjorklund]

We could, but then it would be true by default - where we have mostly tried to keep our struct false by default

[afbjorklund]

Since DynamicSSHAddress doesn't really do much at the moment, we could look at revising both of them?

[afbjorklund]

• Restore DynamicSSHAddress functionality for WSL2 #3988 (comment)

[AkihiroSuda]

Let's keep StaticSSHPort then.

DynamicSSHAddress can be revisited in a separate issue

[afbjorklund]

I will draft a new PR, how we can revise the API (hopefully before 2.0 is out)

Move InspectStatus to the core, and make SSHAddress and GetStatus work

[AkihiroSuda]

Thanks