-
Notifications
You must be signed in to change notification settings - Fork 707
refactor: extract common types and functions from limayaml
& store
#3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c205106
to
1dfd4b5
Compare
Lint is failing. |
VMTypes: vmTypes, | ||
VMTypesEx: vmTypesEx, | ||
GuestAgents: make(map[limayaml.Arch]GuestAgent), | ||
ShellEnvBlock: envutil.GetDefaultBlockList(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where has it gone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my bad. It mistakenly got deleted in commit 5d9na56 🤕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix this? @unsuman
As I mentioned on the chat, do we need to move everything out from limayaml and store just to fix the cycles? Or can we move just the "problematic" ones that are needed by the drivers, so that one can still import limayaml |
66574bd
to
9e583cd
Compare
Checked and I can say that not everything has been moved from the [EDIT]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM, except the ShellEnvBlock regression
Signed-off-by: Ansuman Sahoo <[email protected]>
9e583cd
to
f07bae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Note
This is the first PR out of three PRs. Meging all closes #3769
This PR refactors to use types, constants and functions from the new
pkg/limatype
package instead of the previouspkg/store
andpkg/limayaml
packages. This improves code organisation and updates all relevant imports and usages throughout the codebase. The changes are extensive and touch many files, but are primarily focused on type migration rather than functional changes. These changes are made to avoid cycle import issues, making the code more maintainable and modular.