Do tilde-expansion only once in FillDefaults() #3339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
no-tilde-mountpoint
branch
4 times, most recently
from
d2c0b3f to
fc30873
Compare
We need to do the expansion before we copy the Location over as the default MountPoint because we can't do tilde expansion for guest filenames (the existing call in cidata.go was an error). Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
no-tilde-mountpoint
branch
from
fc30873 to
6ef40ed
Compare
AkihiroSuda
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do the expansion before we copy the Location over as the default MountPoint because we can't do tilde expansion for guest filenames (the existing call in cidata.go was an error).
This will need to be changed even further when we move
FillDefaultsto use the template embedding code: the mountpoint defaults will need to be filled in before mount entries are combined based on a shared mountpoint value. But that is not yet a concern.