taprpc: remove js build tag for taprpc, assetwalletrpc & universerpc
#349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Content looks good to me, though I noticed we forgot to add the |
|
Thanks a lot for the review @guggero! Good catch, I've added |
|
Thanks a lot for the review @ellemouton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement of setting the
jsbuild tag when accessing the JSON callbacks for thetaprpc,assetwalletrpc&universerpcpackages.We've previously removed the
jsbuild tag requirement when using the JSON callbacks for the other LiT sub-servers, and this PR ensures that thetaproot-assetsdoesn't require it either.Happy to address any feedback :)!