conf: sample config for loopd #637

hieblmi · 2023-09-14T09:22:04Z

Addresses #528

This PR introduces a sample configuration file for loopd. The configuration pattern follows the style which was introduced for lnd's sample configuration file in lightningnetwork/lnd#7770.

This PR was tested in regtest by outsourcing the following command line flags to the configuration file:

--network=regtest
--debuglevel=debug
--server.host=localhost:11009
--server.notls
--lnd.host=localhost:10011
--lnd.macaroonpath=.../docker/mounts/regtest/alice/admin.macaroon
--lnd.tlspath=.../docker/mounts/regtest/alice/tls.cert

GeorgeTsagk

Lgtm, thanks for putting all this together! 🔬
I commented on some "LSAT" occurrences to be converted to "L402", but lsat also appears a lot in variables and codebase. Perhaps we could do an all-around renaming in a future iteration

GeorgeTsagk · 2023-09-14T11:59:38Z

sample-loopd.conf

@@ -0,0 +1,171 @@
+; Example configuration for loopd.
+;
+; The default location for this file is in ~/.loop/mainnet/loopd.conf on POSIX


Suggested change

; The default location for this file is in ~/.loop/mainnet/loopd.conf on POSIX

; The default location for this file is in ~/.loop/{mainnet, testnet, regtest}/loopd.conf on POSIX

just a suggestion

GeorgeTsagk · 2023-09-14T12:02:51Z

sample-loopd.conf

+; maxlsatcost=1000
+
+; Maximum routing fee in satoshis that we are willing to pay while paying for an
+; LSAT token.


Suggested change

; LSAT token.

; L402 token.

GeorgeTsagk · 2023-09-14T12:02:59Z

sample-loopd.conf

+; -- You may also specify <subsystem>=<level>,<subsystem2>=<level>,... to set.
+; debuglevel=
+
+; Maximum cost in satoshis that loopd is going to pay for an LSAT token


Suggested change

; Maximum cost in satoshis that loopd is going to pay for an LSAT token

; Maximum cost in satoshis that loopd is going to pay for an L402 token

GeorgeTsagk · 2023-09-14T12:03:46Z

sample-loopd.conf

+; The maximum number of times an off-chain payment may be retried.
+; maxpaymentretries=3
+
+; Enable experimental features: taproot HTLCs and MuSig2 loop out sweeps.


taproot/Musig2 are the default now right?

bhandras

Very nice, thanks! :)

bhandras · 2023-09-14T12:07:11Z

sample-loopd.conf

+; maxpaymentretries=3
+
+; Enable experimental features: taproot HTLCs and MuSig2 loop out sweeps.
+; experimental=false


I'd leave out the taproot HTLCs and MuSig2 from the doc here, since these are now the default.

Can we also remove that flag from the loop app? Can do that in a follow-up if needed.

bhandras · 2023-09-14T12:07:44Z

sample-loopd.conf

+
+[sqlite]
+
+; Skip applying migrations on startup.


Maybe add a comment that this is for development and debugging purposes and should not be played with.

I would just remove them. I don't think the postgres and sqlite fields need to be exposed in the sample conf

bhandras · 2023-09-14T12:08:20Z

sample-loopd.conf

+[postgres]
+
+; Skip applying migrations on startup.
+; postgres.skipmigrations=false


Same as above.

bhandras · 2023-09-14T12:08:42Z

sample-loopd.conf

+; Skip applying migrations on startup.
+; postgres.skipmigrations=false
+
+; Database server hostname.


Perhaps fill with some defaults for a locally running postgres instance.

bhandras · 2023-09-14T12:09:27Z

sample-loopd.conf

+[server]
+
+; Loop server address host:port
+; server.host=


I'd fill the defaults for mainnet here too.

lightninglabs-deploy · 2023-09-21T15:01:46Z

@bhandras: review reminder
@sputn1ck: review reminder
@hieblmi, remember to re-request review from reviewers when ready

sputn1ck

LGTM!

hieblmi requested review from GeorgeTsagk, bhandras and sputn1ck September 14, 2023 09:22

hieblmi force-pushed the sample-conf-file branch from ee89a3d to 25d6b8d Compare September 14, 2023 09:26

GeorgeTsagk approved these changes Sep 14, 2023

View reviewed changes

bhandras reviewed Sep 14, 2023

View reviewed changes

levmi assigned hieblmi Sep 14, 2023

conf: sample config for loopd

07e1254

hieblmi force-pushed the sample-conf-file branch from 25d6b8d to 07e1254 Compare September 19, 2023 07:56

hieblmi requested a review from bhandras September 19, 2023 07:57

sputn1ck approved these changes Sep 27, 2023

View reviewed changes

hieblmi merged commit 58b7400 into lightninglabs:master Sep 27, 2023

hieblmi deleted the sample-conf-file branch September 15, 2025 12:00

	; The default location for this file is in ~/.loop/mainnet/loopd.conf on POSIX
	; The default location for this file is in ~/.loop/{mainnet, testnet, regtest}/loopd.conf on POSIX

	; Maximum cost in satoshis that loopd is going to pay for an LSAT token
	; Maximum cost in satoshis that loopd is going to pay for an L402 token

conf: sample config for loopd #637

conf: sample config for loopd #637

Uh oh!

Conversation

hieblmi commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GeorgeTsagk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bhandras left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lightninglabs-deploy commented Sep 21, 2023

Uh oh!

sputn1ck left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hieblmi commented Sep 14, 2023 •

edited

Loading

GeorgeTsagk left a comment •

edited

Loading