[1/?] Instant loop out: Add FSM module #631
Conversation
hieblmi
left a comment
hieblmi
left a comment
There was a problem hiding this comment.
Good job, I really like the idea of having a common state machine template for future projects so reviewing new features becomes a lot easier in that respect. How did you arrive at choosing this particular one? Did you write it yourself or do we need to add a license disclaimer etc?
sputn1ck
force-pushed
the
instantloopout_1
branch
from
d8a6d52 to
d9cf3e3
Compare
fsm/fsm.go
Outdated
| Previous StateType | ||
|
|
||
| // Current represents the current state. | ||
| Current StateType |
There was a problem hiding this comment.
Given that SendEvent (and then getNextState) changes the Current's and Previous' value we might want to instead expose these as functions that also lock the mutex.
There was a problem hiding this comment.
The mutex is locked for the whole duration of SendEvent. I opted to not export current and previous. It can now only be 'read' by a registeard observer
sputn1ck
force-pushed
the
instantloopout_1
branch
from
d9cf3e3 to
899b6a8
Compare
sputn1ck
force-pushed
the
instantloopout_1
branch
from
899b6a8 to
8bf6b3e
Compare
sputn1ck
force-pushed
the
instantloopout_1
branch
from
8bf6b3e to
4219658
Compare
bhandras
left a comment
bhandras
left a comment
There was a problem hiding this comment.
Looks good, just a few nits/questions remain from my end!
fsm/fsm.go
Outdated
| s.mutex.Lock() | ||
| defer s.mutex.Unlock() | ||
|
|
||
| fsmConfig := s.States |
There was a problem hiding this comment.
nit: do we need this local var?
sputn1ck
force-pushed
the
instantloopout_1
branch
from
4219658 to
94b31fa
Compare
hieblmi
left a comment
hieblmi
left a comment
There was a problem hiding this comment.
LGTM, left some comments. Can't wait to use the FSM for new features.
sputn1ck
force-pushed
the
instantloopout_1
branch
from
94b31fa to
6cf159d
Compare
sputn1ck
force-pushed
the
instantloopout_1
branch
from
6cf159d to
6b79c1d
Compare
sputn1ck
force-pushed
the
instantloopout_1
branch
4 times, most recently
from
1230386 to
ef23fe2
Compare
This commit adds a module for a finite state machine. The goal of the module is to provide a simple, easy to use, and easy to understand finite state machine. The module is designed to be used in future loop subsystems. Additionally a state visualizer is provided to help with understanding the state machine.
sputn1ck
force-pushed
the
instantloopout_1
branch
from
ef23fe2 to
20db07d
Compare
4 participants
This PR adds a module for a finite state machine. The goal of the module is to provide a simple, easy to use, and easy to understand finite state machine. The module is designed to be used in future loop subsystems. Additionally a state visualizer is provided to help with understanding the state machine.
TODO
Next PR: #632