Skip to content

[custom channels]: plumb payinvoice CLI arg #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2024
Merged

[custom channels]: plumb payinvoice CLI arg #838

merged 1 commit into from
Sep 3, 2024

Conversation

@jharveyb
Copy link

Follow up to #817 , partial fix for lightninglabs/taproot-assets#1111 .

@jharveyb jharveyb requested review from GeorgeTsagk and ffranr August 30, 2024 20:57
@dstadulis dstadulis added the tapd label Aug 30, 2024
guggero
guggero approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure what exactly I fixed in #817 but it was clearly not enough.

GeorgeTsagk
GeorgeTsagk approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🙌

@guggero guggero merged commit 1c2cdc1 into 0-19-staging Sep 3, 2024
@guggero guggero deleted the payinvoice-fix branch September 3, 2024 13:31
@Roasbeef Roasbeef mentioned this pull request Sep 3, 2024
Closed
@guggero guggero mentioned this pull request Oct 22, 2024
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeorgeTsagk GeorgeTsagk GeorgeTsagk approved these changes

@ffranr ffranr Awaiting requested review from ffranr

+1 more reviewer

@guggero guggero guggero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jharveyb jharveyb

Labels

tapd

Projects

Taproot-Assets Project Board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jharveyb @guggero @GeorgeTsagk @dstadulis