Add nightly schedule to Docker CD workflow #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
suggested changes
Aug 9, 2024
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
This would now push a tag called master every night, which isn't what we want.
Member
|
Yeah this needs to be constrained further, for now we just want that side branch. |
This commit renames the environment variables to be more accurate and less confusing.
This commit allows us to have different values for the git tag that is checked out (RELEASE_VERSION) and the image tag that we push (IMAGE_TAG).
guggero
force-pushed
the
cd-nightly-docker-builds
branch
from
cc8d54b to
b02f8da
Compare
Contributor
|
Pushed up some fixes. According to the documentation:
Which is why this is going into the |
guggero
approved these changes
Aug 14, 2024
Added a daily schedule to the Docker workflow to automate builds and pushes of the `daily-testing` image. This change introduces a new cron job that runs every day at midnight (UTC) and triggers the workflow.
guggero
force-pushed
the
cd-nightly-docker-builds
branch
from
b02f8da to
2c60753
Compare
Author
|
Nightly builds will be published to this Docker Hub page Should occur in ~7 hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a daily schedule to the Docker workflow to automate builds and
pushes of the
daily-testingimage. This change introduces a new cronjob that runs every day at midnight (UTC) and triggers the workflow.
Additionally, updated the workflow to set different environment
variables for daily builds, including
RELEASE_VERSIONandIMAGE_TAG.These changes enable the automatic creation of daily testing images with
unique tags.
Inspired by:
https://github.com/lightningnetwork/lnd/blob/57a5e4912bced63ce13be06896f64d7e476616b4/.github/workflows/docker.yml#L7-L44