terminal: allow wallet unlocker services REST calls #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I keep forgetting that we now also have file based release notes in |
ViktorT-11
approved these changes
Jul 29, 2024
Contributor
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
Awesome, thanks for the fix 🙏! LGTM 🚀
| // set up, we need to override the isReady check for this specific | ||
| // URI as soon as LND can accept the call, i.e. when the lnd sub-server | ||
| // is in the "Wallet Ready" state. | ||
| lndOverride := func(uri, manualStatus string) (bool, bool) { |
Contributor
There was a problem hiding this comment.
Nit: The comment above here for lndOverride is maybe a bit misplaced now that /lnrpc.State/GetState URI has been moved to a map. I'm fine to keep it as is if you think that the comment is still ok here :).
When lnd isn't marked as fully ready yet, we didn't allow any REST methods through. But to allow creating a wallet through REST, we also need to allow these methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805.
When lnd isn't marked as fully ready yet, we didn't allow any REST methods through. But to allow creating a wallet through REST, we also need to allow these methods.