-
Notifications
You must be signed in to change notification settings - Fork 109
build: v0.13.3 alpha #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: v0.13.3 alpha #804
Conversation
c8eaac0 to
42a43a6
Compare
|
oops ... fixing the break now |
|
You need this: lightning-terminal/subservers/taproot-assets.go Lines 198 to 209 in 68ed0bd
And you can pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review looks good! Will test this once the protos have been updated and compilation errors have been addressed.
We should also cut the release notes with this PR :)!
README.md
Outdated
|
|
||
| | LiT | LND | | ||
| |-------------------|--------------| | ||
| | **v0.13.3-alpha** | v0.17.0-beta | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that this should be changed after checking with @guggero offline :)
| | **v0.13.3-alpha** | v0.17.0-beta | | |
| | **v0.13.3-alpha** | v0.17.1-beta | |
42a43a6 to
81bcaa6
Compare
tapd to 2bf18437 and loop to v0.28.6-beta
b610135 to
24598e7
Compare
guggero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
ViktorT-11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK LGTM 🚀🔥!! Thanks a lot 🙏
|
|
||
| # Autopilot | ||
|
|
||
| # Contributors (Alphabetical Order) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: You should add your name to the Contributors list given this PR :)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think this PR counts as a contribution imo 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok 😄
Still waiting for local run of
make protosto complete so pushing the PR so long for review.Bumps tapd -> https://github.com/lightninglabs/taproot-assets/tree/v0-4-1-lnd-18
Bumps loop -> v0.28.6-beta