Skip to content

Conversation

@ellemouton
Copy link
Member

Still waiting for local run of make protos to complete so pushing the PR so long for review.

Bumps tapd -> https://github.com/lightninglabs/taproot-assets/tree/v0-4-1-lnd-18
Bumps loop -> v0.28.6-beta

@ellemouton ellemouton requested a review from ViktorT-11 July 25, 2024 16:35
@ellemouton ellemouton added the no-changelog This PR is does not require a release notes entry label Jul 25, 2024
@ellemouton
Copy link
Member Author

oops ... fixing the break now

@guggero
Copy link
Contributor

guggero commented Jul 25, 2024

You need this:

publicUniRead := strings.Contains(
t.cfg.Universe.PublicAccess,
string(tap.UniversePublicAccessStatusRead),
)
publicUniWrite := strings.Contains(
t.cfg.Universe.PublicAccess,
string(tap.UniversePublicAccessStatusWrite),
)
return perms.MacaroonWhitelist(
publicUniRead || t.remote, publicUniWrite || t.remote,
t.cfg.RpcConf.AllowPublicUniProofCourier || t.remote,
t.cfg.RpcConf.AllowPublicStats || t.remote,

And you can pass false as the new litdIntegrated argument of ConfigureSubServer.

Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review looks good! Will test this once the protos have been updated and compilation errors have been addressed.

We should also cut the release notes with this PR :)!

README.md Outdated

| LiT | LND |
|-------------------|--------------|
| **v0.13.3-alpha** | v0.17.0-beta |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this should be changed after checking with @guggero offline :)

Suggested change
| **v0.13.3-alpha** | v0.17.0-beta |
| **v0.13.3-alpha** | v0.17.1-beta |

@ellemouton ellemouton removed the no-changelog This PR is does not require a release notes entry label Jul 25, 2024
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀🔥!! Thanks a lot 🙏


# Autopilot

# Contributors (Alphabetical Order)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You should add your name to the Contributors list given this PR :)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this PR counts as a contribution imo 🙃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok 😄

@ellemouton ellemouton merged commit 00b2f7e into master Jul 26, 2024
@ellemouton ellemouton deleted the lit-v0.13.3-alpha branch July 26, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants