Skip to content

Conversation

@Roasbeef
Copy link
Member

No description provided.

@Roasbeef Roasbeef changed the title build: bump version to v0.17.1-beta build: bump version of lnd to v0.17.1-beta Nov 14, 2023
@ViktorT-11 ViktorT-11 changed the title build: bump version of lnd to v0.17.1-beta build: update litd to version v0.12.1-alpha Nov 15, 2023
@ViktorT-11
Copy link
Contributor

ViktorT-11 commented Nov 15, 2023

Updated the PR to fix the failing itests. Also bumped the loop & taproot-assets dependencies! Finally I also edited the README file.

Edit:
Got a new itest error, will fix that and update this PR once more.

@ViktorT-11 ViktorT-11 requested review from ellemouton and removed request for ellemouton November 15, 2023 19:26
@ViktorT-11
Copy link
Contributor

Updated the itests to be compatible with the updates of taproot-assets v0.3.1-alpha.

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Bump lnd to `v0.17.1-beta`, loop to `v0.26.5-beta` and taproot-assets to
`v0.3.1-alpha`.

With commit `76862ed` in lnd v0.17.1-beta, lnd will return an
"invalid ID" error for any calls with an unknown macaroon version.
Therefore our itests that uses a dummy macaroon was also updated to
expect this error.

With tapd `v0.3.1-alpha`, the universerpc Info rpc response is changed,
which removes the `num_assets` field in the response.
This commit therefore also updates the `taprpc-whitelist` itest
successPattern to match the new response.
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

Tested Loop & Pool via the UI. All good.

@ViktorT-11 ViktorT-11 merged commit 8b60f1c into master Nov 16, 2023
@guggero guggero deleted the 0-17-1-lnd branch May 23, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants