Skip to content

Conversation

@Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented Jul 5, 2023

No description provided.

@ViktorT-11 ViktorT-11 self-requested a review July 6, 2023 09:26
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me :)! Just a few small changes suggested.
Windows CI build failure seems unrelated.

Also:
Would we also like to bump loop to the latest version in this PR?

@levmi
Copy link
Contributor

levmi commented Jul 6, 2023

Seems reasonable to bump Loop as well, it's a pretty major change wrt moving to a SQLite backend option. I'm not sure if that has any impact on our process, but if you're willing @ViktorTigerstrom, it's probably worth you picking this up and pushing it over the finish line? (tomorrow your time obviously not tonight :)

@ViktorT-11
Copy link
Contributor

ViktorT-11 commented Jul 7, 2023

Updated the PR to also bump loop, and addressed my feedback above :)!

ViktorT-11 and others added 2 commits July 7, 2023 13:59
bump lnd to v0.16.4, tapd to v0.2.2 and loop to v0.25.2-beta
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 🎸

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ellemouton ellemouton requested a review from jamaljsr July 10, 2023 09:53
@levmi levmi requested review from itsrachelfish and jbrill July 12, 2023 14:38
Copy link
Contributor

@itsrachelfish itsrachelfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, created a few sessions and confirmed they worked in terminal-web with loop

@ellemouton ellemouton merged commit 36eae58 into master Jul 13, 2023
@ellemouton ellemouton deleted the tap-v0.2.2 branch July 13, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants