-
Notifications
You must be signed in to change notification settings - Fork 109
build: bump lnd to v0.16.4 and tapd to v0.2.2 #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me :)! Just a few small changes suggested.
Windows CI build failure seems unrelated.
Also:
Would we also like to bump loop to the latest version in this PR?
|
Seems reasonable to bump Loop as well, it's a pretty major change wrt moving to a SQLite backend option. I'm not sure if that has any impact on our process, but if you're willing @ViktorTigerstrom, it's probably worth you picking this up and pushing it over the finish line? (tomorrow your time obviously not tonight :) |
|
Updated the PR to also bump loop, and addressed my feedback above :)! |
bump lnd to v0.16.4, tapd to v0.2.2 and loop to v0.25.2-beta
ellemouton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 🎸
guggero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
itsrachelfish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK, created a few sessions and confirmed they worked in terminal-web with loop
No description provided.