Skip to content

Conversation

@ellemouton
Copy link
Member

@ellemouton ellemouton commented May 19, 2023

This PR bumps the lndclient version to one that ensures that a more meaningful error
is returned if RegisterRPCMiddleware fails. Currently, the wanted error will be logged but
the official error will be context cancelled which is not very helpful.

This will be especially important once #541 is merged since we want
meaningful errors to be displayed.

@ellemouton ellemouton requested a review from ViktorT-11 May 19, 2023 11:10
Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellemouton ellemouton merged commit 7fc892d into lightninglabs:master May 19, 2023
@ellemouton ellemouton deleted the lndClientBump branch May 19, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants