multi: always use Lit's TLS cert #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
approved these changes
Feb 22, 2023
Member
ellemouton
left a comment
ellemouton
left a comment
There was a problem hiding this comment.
LGTM once Oli's comments are addressed 👍
ellemouton
requested changes
Feb 22, 2023
Member
ellemouton
left a comment
ellemouton
left a comment
There was a problem hiding this comment.
Oops - actually - Looks like this diff causes the itests to never clean up...
positiveblue
force-pushed
the
lit-tls-cert
branch
2 times, most recently
from
c4b33a8 to
1451b68
Compare
ellemouton
approved these changes
Feb 23, 2023
Member
ellemouton
left a comment
ellemouton
left a comment
There was a problem hiding this comment.
Niiiiice 🔥 Thanks @positiveblue !!!
Just needs a rebase and then we are g2g 🚀
In this commit, we remove Lit's dependency on LND's tls cert in integrated mode. With this commit, even if Lit is started in integrated mode, it will create its own tls cert to use for serving the webserver.
Close connections when we are not going to use them anymore (usually a `defer` is enough)
positiveblue
force-pushed
the
lit-tls-cert
branch
from
1451b68 to
8e6ef3f
Compare
Contributor
Author
|
👀 it was a rebase without any conflicts... Is this a limitation that applies to this project for some specific reason (js? or something?) |
Contributor
|
I think it's a specific branch protection setting in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we remove Lit's dependency on LND's tls cert in integrated mode. With this commit, even if Lit is started in integrated mode, it will create its own tls cert to use for serving the webserver.
Was part of #442