Skip to content

session+litrpc: change RevokedAt tlv and proto number #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2023
Merged

session+litrpc: change RevokedAt tlv and proto number #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f4f9f7
session: change revoked at to tlv type 16
ellemouton Jan 11, 2023
1f78f29
litrpc: let revoked_at use type 16
ellemouton Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 57 additions & 56 deletions litrpc/lit-sessions.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion litrpc/lit-sessions.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,16 @@ message Session {

string account_id = 13;

/*
Field number 14 is reserved for future use.
*/
reserved 14;

/*
Field number 15 is reserved for future use.
*/
reserved 15;

/*
The unix timestamp indicating the time at which the session was revoked.
Note that this field has not been around since the beginning and so it
Expand All @@ -101,7 +111,7 @@ message Session {
readers should not assume that if this field is zero that the session is
not revoked. Readers should instead first check the session_state field.
*/
uint64 revoked_at = 14 [jstype = JS_STRING];
uint64 revoked_at = 16 [jstype = JS_STRING];
}

message MacaroonRecipe {
Expand Down
4 changes: 3 additions & 1 deletion session/tlv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ const (
typeRemotePublicKey tlv.Type = 11
typeMacaroonRecipe tlv.Type = 12
typeCreatedAt tlv.Type = 13
typeRevokedAt tlv.Type = 14
typeReservedNum1 tlv.Type = 14
typeReservedNum2 tlv.Type = 15
typeRevokedAt tlv.Type = 16

// typeMacaroon is no longer used, but we leave it defined for backwards
// compatibility.
Expand Down