proto: add generated types for lit-accounts #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've created a fix for the linter issue in #473. |
jamaljsr
force-pushed
the
add-account-rpc-types
branch
from
960d91b to
36f3e29
Compare
Member
Author
|
Rebased on |
jamaljsr
force-pushed
the
add-account-rpc-types
branch
from
36f3e29 to
342cf24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
build-protos.jsscript to generate the necessary TS/JS library files from thelit-accounts.protoRPC definitions.The
litrpcprotos are copied into theprotodir because thesanatizefunction will add the[jstype = JS_STRING]modifier tounint64values. I didn't think it was a good idea to have the script overwrite the source files in thelitrpcdir. I'm open to feedback on this.